On Thu, Dec 11, 2025 at 11:43:27AM -0500, Tom Lane wrote:
> And before that, you'd have to get consensus that sizeof(*var) *is*
> the preferred style. I for one don't like it a bit. IMO what it
> mostly accomplishes is to remove a cue as to what we are allocating.
> I don't agree that it removes
Hi,
On Thu, Dec 11, 2025 at 11:43:27AM -0500, Tom Lane wrote:
> Andres Freund writes:
> > I tend to agree that what you propose is the better style, but I seriously
> > doubt that
>
> > a) changing over everything at once is worth the backpatch hazard and review
> >pain
> > b) that to judge
Hi,
On Thu, Dec 11, 2025 at 05:56:13PM +0100, Álvaro Herrera wrote:
> I have my part of blame for having committed the mass change to
> XLogRecPtrIsValid in a2b02293bc65. I'm starting to regret that now.
After reflecting on this one, I do agree that this one was probably not worth
the mass chang
Hi,
On Thu, Dec 11, 2025 at 10:39:55AM -0500, Andres Freund wrote:
> Hi,
>
> On 2025-12-11 13:27:56 +, Bertrand Drouvot wrote:
> > - 0002 is a very large patch. I think that it provides added value as
> > mentioned
> > above but I'm not sure it is worth the noise. Anyway it is done, so shari
On 2025-Dec-11, Andres Freund wrote:
> a) changing over everything at once is worth the backpatch hazard and review
>pain
The other issue with these giant patches is that they cause many largish
patches waiting in the commitfest process to require rebases, which are
sometimes not trivial to d
Andres Freund writes:
> I tend to agree that what you propose is the better style, but I seriously
> doubt that
> a) changing over everything at once is worth the backpatch hazard and review
>pain
> b) that to judge whether we should do this a 277kB patch is useful
> c) that changing the exis
Hi,
On 2025-12-11 13:27:56 +, Bertrand Drouvot wrote:
> - 0002 is a very large patch. I think that it provides added value as
> mentioned
> above but I'm not sure it is worth the noise. Anyway it is done, so sharing
> here to get your thoughts.
I find the recent trend to sent auto-generated
