Re: FinishPreparedTransaction missing HOLD_INTERRUPTS section

2018-05-03 Thread Teodor Sigaev
Thank you, pushed! Stas Kelvich wrote: Hello. It seems that during COMMIT PREPARED FinishPreparedTransaction() doesn't hold interrupts around writing to wal and cleaning up ProcArray and GXact entries. At least RemoveTwoPhaseFile (which is called in between) can print a warning with ereport(),

Re: FinishPreparedTransaction missing HOLD_INTERRUPTS section

2018-04-27 Thread Michael Paquier
On Sat, Apr 28, 2018 at 12:36:16AM +0300, Stas Kelvich wrote: > It seems that during COMMIT PREPARED FinishPreparedTransaction() doesn't > hold interrupts around writing to wal and cleaning up ProcArray and GXact > entries. At least RemoveTwoPhaseFile (which is called in between) can print > a warn