Re: Feature improvement for pg_stat_statements

2020-12-17 Thread Fujii Masao
On 2020/12/17 22:59, Seino Yuki wrote: 2020-12-14 23:01 に Fujii Masao さんは書きました: On 2020/12/14 18:17, Seino Yuki wrote: 2020-12-09 21:14 に Fujii Masao さんは書きました: On 2020/12/09 20:42, Li Japin wrote: Hi, On Dec 9, 2020, at 6:37 PM, Seino Yuki mailto:sein...@oss.nttdata.com>> wrote: 2020-12

Re: Feature improvement for pg_stat_statements

2020-12-17 Thread Seino Yuki
2020-12-14 23:01 に Fujii Masao さんは書きました: On 2020/12/14 18:17, Seino Yuki wrote: 2020-12-09 21:14 に Fujii Masao さんは書きました: On 2020/12/09 20:42, Li Japin wrote: Hi, On Dec 9, 2020, at 6:37 PM, Seino Yuki > wrote: 2020-12-01 01:04 に Fujii Masao さんは書きました: On 2020

Re: Feature improvement for pg_stat_statements

2020-12-14 Thread Fujii Masao
On 2020/12/14 18:17, Seino Yuki wrote: 2020-12-09 21:14 に Fujii Masao さんは書きました: On 2020/12/09 20:42, Li Japin wrote: Hi, On Dec 9, 2020, at 6:37 PM, Seino Yuki mailto:sein...@oss.nttdata.com>> wrote: 2020-12-01 01:04 に Fujii Masao さんは書きました: On 2020/11/30 23:05, Seino Yuki wrote: 2020-11-

Re: Feature improvement for pg_stat_statements

2020-12-14 Thread Seino Yuki
2020-12-09 21:14 に Fujii Masao さんは書きました: On 2020/12/09 20:42, Li Japin wrote: Hi, On Dec 9, 2020, at 6:37 PM, Seino Yuki > wrote: 2020-12-01 01:04 に Fujii Masao さんは書きました: On 2020/11/30 23:05, Seino Yuki wrote: 2020-11-30 15:02 に Fujii Masao さんは書きました: On 2020

Re: Feature improvement for pg_stat_statements

2020-12-09 Thread Fujii Masao
On 2020/12/09 20:42, Li Japin wrote: Hi, On Dec 9, 2020, at 6:37 PM, Seino Yuki mailto:sein...@oss.nttdata.com>> wrote: 2020-12-01 01:04 に Fujii Masao さんは書きました: On 2020/11/30 23:05, Seino Yuki wrote: 2020-11-30 15:02 に Fujii Masao さんは書きました: On 2020/11/30 12:08, Seino Yuki wrote: 2020-11

Re: Feature improvement for pg_stat_statements

2020-12-09 Thread Li Japin
Hi, On Dec 9, 2020, at 6:37 PM, Seino Yuki mailto:sein...@oss.nttdata.com>> wrote: 2020-12-01 01:04 に Fujii Masao さんは書きました: On 2020/11/30 23:05, Seino Yuki wrote: 2020-11-30 15:02 に Fujii Masao さんは書きました: On 2020/11/30 12:08, Seino Yuki wrote: 2020-11-27 22:39 に Fujii Masao さんは書きました: On 2020/11/2

Re: Feature improvement for pg_stat_statements

2020-12-09 Thread Seino Yuki
2020-12-01 01:04 に Fujii Masao さんは書きました: On 2020/11/30 23:05, Seino Yuki wrote: 2020-11-30 15:02 に Fujii Masao さんは書きました: On 2020/11/30 12:08, Seino Yuki wrote: 2020-11-27 22:39 に Fujii Masao さんは書きました: On 2020/11/27 21:39, Seino Yuki wrote: 2020-11-27 21:37 に Seino Yuki さんは書きました: 2020-11-16

Re: Feature improvement for pg_stat_statements

2020-11-30 Thread Fujii Masao
On 2020/11/30 23:05, Seino Yuki wrote: 2020-11-30 15:02 に Fujii Masao さんは書きました: On 2020/11/30 12:08, Seino Yuki wrote: 2020-11-27 22:39 に Fujii Masao さんは書きました: On 2020/11/27 21:39, Seino Yuki wrote: 2020-11-27 21:37 に Seino Yuki さんは書きました: 2020-11-16 12:28 に Seino Yuki さんは書きました: Due to si

Re: Feature improvement for pg_stat_statements

2020-11-30 Thread Seino Yuki
2020-11-30 15:02 に Fujii Masao さんは書きました: On 2020/11/30 12:08, Seino Yuki wrote: 2020-11-27 22:39 に Fujii Masao さんは書きました: On 2020/11/27 21:39, Seino Yuki wrote: 2020-11-27 21:37 に Seino Yuki さんは書きました: 2020-11-16 12:28 に Seino Yuki さんは書きました: Due to similar fixed, we have also merged the patches

Re: Feature improvement for pg_stat_statements

2020-11-29 Thread Fujii Masao
On 2020/11/30 12:08, Seino Yuki wrote: 2020-11-27 22:39 に Fujii Masao さんは書きました: On 2020/11/27 21:39, Seino Yuki wrote: 2020-11-27 21:37 に Seino Yuki さんは書きました: 2020-11-16 12:28 に Seino Yuki さんは書きました: Due to similar fixed, we have also merged the patches discussed in the following thread. ht

Re: Feature improvement for pg_stat_statements

2020-11-29 Thread Seino Yuki
2020-11-27 22:39 に Fujii Masao さんは書きました: On 2020/11/27 21:39, Seino Yuki wrote: 2020-11-27 21:37 に Seino Yuki さんは書きました: 2020-11-16 12:28 に Seino Yuki さんは書きました: Due to similar fixed, we have also merged the patches discussed in the following thread. https://commitfest.postgresql.org/30/2736/ T

Re: Feature improvement for pg_stat_statements

2020-11-27 Thread Fujii Masao
On 2020/11/27 21:39, Seino Yuki wrote: 2020-11-27 21:37 に Seino Yuki さんは書きました: 2020-11-16 12:28 に Seino Yuki さんは書きました: Due to similar fixed, we have also merged the patches discussed in the following thread. https://commitfest.postgresql.org/30/2736/ The patch is posted on the 2736 side of t

Re: Feature improvement for pg_stat_statements

2020-11-27 Thread Seino Yuki
2020-11-27 21:37 に Seino Yuki さんは書きました: 2020-11-16 12:28 に Seino Yuki さんは書きました: Due to similar fixed, we have also merged the patches discussed in the following thread. https://commitfest.postgresql.org/30/2736/ The patch is posted on the 2736 side of the thread. Regards. I forgot the attac

Re: Feature improvement for pg_stat_statements

2020-11-27 Thread Seino Yuki
2020-11-16 12:28 に Seino Yuki さんは書きました: Due to similar fixed, we have also merged the patches discussed in the following thread. https://commitfest.postgresql.org/30/2736/ The patch is posted on the 2736 side of the thread. Regards. The following patches have been committed and we have created

Re: Feature improvement for pg_stat_statements

2020-11-15 Thread Seino Yuki
Due to similar fixed, we have also merged the patches discussed in the following thread. https://commitfest.postgresql.org/30/2736/ The patch is posted on the 2736 side of the thread. Regards.

Re: Feature improvement for pg_stat_statements

2020-11-09 Thread Seino Yuki
Thank you for pointing that out. I'll post a fixed patch. + SpinLockAcquire(&pgss->mutex); You might noticed, but there a purpose of using the following idiom. Without that, compiler might optimize out the comparison assuming *pgss won't change. volatile pgssSharedState

Re: Feature improvement for pg_stat_statements

2020-10-16 Thread Kyotaro Horiguchi
At Fri, 16 Oct 2020 10:47:50 +, Yuki Seino wrote in > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, failed > Spec compliant: tested, passed > Documentation:tested,

Re: Feature improvement for pg_stat_statements

2020-10-16 Thread Yuki Seino
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, failed Spec compliant: tested, passed Documentation:tested, failed The patch applies cleanly and looks fine to me.I'm going to l

Re: Feature improvement for pg_stat_statements

2020-09-23 Thread btnakamichin
2020-09-22 04:58 に Andres Freund さんは書きました: Hi, On 2020-09-18 17:55:12 +0900, btnakamichin wrote: I’m thinking of adding adding a function called pg_stat_statements_reset_time() that returns the last timestamp when executed pg_stat_statements_reset(). pg_stat_statements can reset each SQL state

Re: Feature improvement for pg_stat_statements

2020-09-21 Thread Andres Freund
Hi, On 2020-09-18 17:55:12 +0900, btnakamichin wrote: > I’m thinking of adding adding a function called > pg_stat_statements_reset_time() that returns the last timestamp when > executed pg_stat_statements_reset(). pg_stat_statements can reset each SQL > statement. We can record each sql reset timi

Re: Feature improvement for pg_stat_statements

2020-09-18 Thread Adam Brusselback
That'd be useful in my book. My scripts just have a hard coded timestamp I replace when I call reset so those calculations work, but it would be much preferred to have that data available by a built in function. -Adam