Re: Feature Request: Add AES-128-CFB Mode Support to pgcrypto

2025-02-14 Thread Daniel Gustafsson
> On 5 Feb 2025, at 18:28, Daniel Gustafsson wrote: > >> On 5 Feb 2025, at 18:24, Álvaro Herrera wrote: > >> Anyway, at least the bytes appear to be interpreted the same by both >> openssl and this new function, so that's good news. > > Thanks for confirming. Short of a very small doc change

Re: Feature Request: Add AES-128-CFB Mode Support to pgcrypto

2025-02-05 Thread Álvaro Herrera
On 2025-Jan-29, Umar Hayat wrote: > Hi Daniel Gustafsson and Vladyslav Nebozhyn, > I created a patch for CFB mode for AES encryption. Please have a look > and let me know what you think. > Patch covers implementation, tests and documentation changes. > > OpenSSL profives aes-cfb1, aes-cfb8 and ae

Re: Feature Request: Add AES-128-CFB Mode Support to pgcrypto

2025-02-05 Thread Daniel Gustafsson
> On 5 Feb 2025, at 18:24, Álvaro Herrera wrote: > Anyway, at least the bytes appear to be interpreted the same by both > openssl and this new function, so that's good news. Thanks for confirming. Short of a very small doc change (which I don't have handy on this laptop) I think this patch is r

Re: Feature Request: Add AES-128-CFB Mode Support to pgcrypto

2025-01-31 Thread Umar Hayat
Hi Vladyslav, No Problem, I also did not realize that you will be implementing it. So I spent a couple of hours and provided a patch. Also created commitfest entry as well, Please do review the patch and let me know if this is sufficient at least for your use case. Regards, Umar Hayat Bitnine (htt

Re: Feature Request: Add AES-128-CFB Mode Support to pgcrypto

2025-01-29 Thread Vladyslav Nebozhyn
Dear Umar, I sincerely apologize for missing your email earlier. I truly appreciate the time and effort you put into creating the patch—it looks great! Thank you for your work on this and for contributing to the solution so quickly. I’m really glad to see this enhancement being added to pgcrypto,

Re: Feature Request: Add AES-128-CFB Mode Support to pgcrypto

2025-01-29 Thread Vladyslav Nebozhyn
Dear Daniel Gustafsson, Thank you for your response and for offering to review the patch. I really appreciate your time and willingness to assist with this! I've prepared a patch to add AES-CFB support to pgcrypto, following the existing structure used for other AES modes. Integrating it for AES

Re: Feature Request: Add AES-128-CFB Mode Support to pgcrypto

2025-01-29 Thread Umar Hayat
Hi Daniel Gustafsson and Vladyslav Nebozhyn, I created a patch for CFB mode for AES encryption. Please have a look and let me know what you think. Patch covers implementation, tests and documentation changes. OpenSSL profives aes-cfb1, aes-cfb8 and aes-cfb128 modes where aes-cfb defaults to aes-cf

Re: Feature Request: Add AES-128-CFB Mode Support to pgcrypto

2025-01-28 Thread Daniel Gustafsson
> On 28 Jan 2025, at 11:46, Vladyslav Nebozhyn wrote: > • Ease of Implementation: OpenSSL already provides a straightforward API > for AES-128-CFB, so adding it to pgcrypto should require only a few lines of > code. IIRC we already support CFB for Blowfish so I think it would be quite easy