Re: Fault injection framework

2019-09-06 Thread Asim R P
On Tue, Aug 27, 2019 at 6:57 PM Asim R P wrote: > > On Tue, Aug 27, 2019 at 12:35 PM Michael Paquier wrote: > > > > Things like exec_fault_injector_command() need to be more documented. > > It is hard to guess what it is being used for. > > Added a comment to explain things a bit. Hope that help

Re: Fault injection framework

2019-08-27 Thread Asim R P
On Tue, Aug 27, 2019 at 12:35 PM Michael Paquier wrote: > > You may want to double-check whitespaces in your patch set, and 0002 > does not apply because of conflicts in isolationtester.h (my fault!). > I've rebased the patch set against the latest master and tried to resolve whitespace issues.

Re: Fault injection framework

2019-08-27 Thread Michael Paquier
On Thu, Aug 22, 2019 at 07:45:09PM +0530, Asim R P wrote: > Fault injection was discussed a few months ago at PGCon in Ottawa. At > least a few folks showed interest and so I would like to present what we > have been using in Greenplum. > > The attached patch set contains the fault injector frame