Re: Failed assertion due to procedure created with SECURITY DEFINER option

2018-07-13 Thread Peter Eisentraut
On 12.07.18 21:52, Jonathan S. Katz wrote: > So it handles it as expected. Committed. > Code and test cases look fine to me from what I can tell. My only suggestion > would be if we could add some guidance to the documentation on what > languages > can support transaction control statements insid

Re: Failed assertion due to procedure created with SECURITY DEFINER option

2018-07-12 Thread Jonathan S. Katz
> On Jul 4, 2018, at 3:43 AM, Peter Eisentraut > wrote: > > On 03.07.18 19:20, Andres Freund wrote: >> On 2018-06-29 10:19:17 -0700, Andres Freund wrote: >>> Hi, >>> >>> On 2018-06-29 13:56:12 +0200, Peter Eisentraut wrote: On 6/29/18 13:07, amul sul wrote: > This happens because of i

Re: Failed assertion due to procedure created with SECURITY DEFINER option

2018-07-04 Thread Peter Eisentraut
On 03.07.18 19:20, Andres Freund wrote: > On 2018-06-29 10:19:17 -0700, Andres Freund wrote: >> Hi, >> >> On 2018-06-29 13:56:12 +0200, Peter Eisentraut wrote: >>> On 6/29/18 13:07, amul sul wrote: This happens because of in fmgr_security_definer() function we are changing global variabl

Re: Failed assertion due to procedure created with SECURITY DEFINER option

2018-07-03 Thread Andres Freund
On 2018-06-29 10:19:17 -0700, Andres Freund wrote: > Hi, > > On 2018-06-29 13:56:12 +0200, Peter Eisentraut wrote: > > On 6/29/18 13:07, amul sul wrote: > > > This happens because of in fmgr_security_definer() function we are > > > changing global variable SecurityRestrictionContext and in the >

Re: Failed assertion due to procedure created with SECURITY DEFINER option

2018-07-03 Thread amul sul
On Fri, Jun 29, 2018 at 5:26 PM Peter Eisentraut wrote: > > On 6/29/18 13:07, amul sul wrote: > > This happens because of in fmgr_security_definer() function we are > > changing global variable SecurityRestrictionContext and in the > > StartTransaction() insisting it should be zero, which is the

Re: Failed assertion due to procedure created with SECURITY DEFINER option

2018-06-29 Thread Andres Freund
Hi, On 2018-06-29 13:56:12 +0200, Peter Eisentraut wrote: > On 6/29/18 13:07, amul sul wrote: > > This happens because of in fmgr_security_definer() function we are > > changing global variable SecurityRestrictionContext and in the > > StartTransaction() insisting it should be zero, which is the

Re: Failed assertion due to procedure created with SECURITY DEFINER option

2018-06-29 Thread Peter Eisentraut
On 6/29/18 13:07, amul sul wrote: > This happens because of in fmgr_security_definer() function we are > changing global variable SecurityRestrictionContext and in the > StartTransaction() insisting it should be zero, which is the problem. Hmm, what is the reason for this insistation? We could w