Re: FSM doesn't recover after zeroing damaged page.

2025-03-24 Thread Anton A. Melnikov
Hi! On 16.03.2025 16:03, vignesh C wrote: I noticed that Kirill's comments from [1] are not yet addressed, I have changed the status of commitfest entry to Waiting on Author, kindly address them and update the status to Needs review. [1] - https://www.postgresql.org/message-id/CALdSSPjg0hBUvPAS

Re: FSM doesn't recover after zeroing damaged page.

2025-03-16 Thread vignesh C
On Fri, 7 Feb 2025 at 05:45, Anton A. Melnikov wrote: > > Here is a small patch that does it and eliminates multiple warnings. > Would be glad if you take a look on it. I noticed that Kirill's comments from [1] are not yet addressed, I have changed the status of commitfest entry to Waiting on Aut

Re: FSM doesn't recover after zeroing damaged page.

2025-03-10 Thread Kirill Reshke
Hi! On Fri, 7 Feb 2025 at 05:15, Anton A. Melnikov wrote: > > Hi! > I noticed that the updated page is not written to disk because the > buffer where it is located is not marked dirty. Moreover > MarkBufferDirtyHint(), > which is called for modified FSM pages, seems is not suitable here, > sinc

Re: FSM doesn't recover after zeroing damaged page.

2025-03-10 Thread Stepan Neretin
On Fri, Feb 7, 2025 at 7:15 AM Anton A. Melnikov wrote: > Hi! > > At the current master i found that if not the last page of > the FSM bottom layer was corrupted it is not restored after zeroing. > > Here is reproduction like that: > 1) Create a table with FSM of 4 pages: > create table t (int) a