Re: Extend win32 error codes to errno mapping in win32error.c

2022-09-28 Thread Michael Paquier
On Wed, Sep 28, 2022 at 11:14:53AM +0530, Bharath Rupireddy wrote: > IMO, we can add mapping for just ERROR_INVALID_NAME which is an > obvious error code and easy to hit, leaving others. Okidoki. Applied the minimalistic version, then. -- Michael signature.asc Description: PGP signature

Re: Extend win32 error codes to errno mapping in win32error.c

2022-09-27 Thread Michael Paquier
On Wed, Sep 28, 2022 at 11:14:53AM +0530, Bharath Rupireddy wrote: > IMO, we can add mapping for just ERROR_INVALID_NAME which is an > obvious error code and easy to hit, leaving others. There are actually > many win32 error codes that may get hit in our code base and actually > mapping everything

Re: Extend win32 error codes to errno mapping in win32error.c

2022-09-27 Thread Bharath Rupireddy
On Wed, Sep 28, 2022 at 10:10 AM Michael Paquier wrote: > > One important thing, in my opinion, when it comes to updating this > table, is that it could be better to report the original error number > if errno can be somewhat confusing for the mapping. Returning errno = e instead of EINVAL in _do

Re: Extend win32 error codes to errno mapping in win32error.c

2022-09-27 Thread Michael Paquier
On Tue, Sep 27, 2022 at 03:23:04PM +0530, Bharath Rupireddy wrote: > The failure occurs in dosmaperr() in win32error.c due to an unmapped > errno for win32 error code. The error code 123 i.e. ERROR_INVALID_NAME > says "The file name, directory name, or volume label syntax is > incorrect." [2], the