Re: Explicitly skip TAP tests under Meson if disabled

2023-11-15 Thread Andres Freund
On 2023-11-15 11:02:19 +0100, Peter Eisentraut wrote: > On 04.11.23 01:51, Andres Freund wrote: > > I'd just use a single test() invocation here, and add an argument to > > testwrap > > indicating that it should print out the skipped message. That way we a) > > don't > > need two test() invocatio

Re: Explicitly skip TAP tests under Meson if disabled

2023-11-15 Thread Peter Eisentraut
On 04.11.23 01:51, Andres Freund wrote: I'd just use a single test() invocation here, and add an argument to testwrap indicating that it should print out the skipped message. That way we a) don't need two test() invocations, b) could still see the test name etc in the test invocation. Here is a

Re: Explicitly skip TAP tests under Meson if disabled

2023-11-06 Thread Andres Freund
Hi, On 2023-11-06 17:46:23 +0100, Peter Eisentraut wrote: > On 04.11.23 01:51, Andres Freund wrote: > > I'd just use a single test() invocation here, and add an argument to > > testwrap > > indicating that it should print out the skipped message. That way we a) > > don't > > need two test() invo

Re: Explicitly skip TAP tests under Meson if disabled

2023-11-06 Thread Peter Eisentraut
On 04.11.23 01:51, Andres Freund wrote: I'd just use a single test() invocation here, and add an argument to testwrap indicating that it should print out the skipped message. That way we a) don't need two test() invocations, b) could still see the test name etc in the test invocation. Is testwr

Re: Explicitly skip TAP tests under Meson if disabled

2023-11-03 Thread Andres Freund
Hi, On 2023-10-30 05:45:52 -0400, Peter Eisentraut wrote: > Under Meson, it is not very easy to see if TAP tests have been enabled or > disabled, if you rely on the default auto setting. You either need to > carefully study the meson setup output, or you notice, what a minute, didn't > there use

Re: Explicitly skip TAP tests under Meson if disabled

2023-11-02 Thread Peter Eisentraut
On 30.10.23 10:12, Tom Lane wrote: +1 for counting such tests as "skipped" in the summary. -1 for emitting a message per skipped test. If I'm intentionally not running those tests, that would be very annoying noise, and potentially would obscure messages I actually need to see. In my usage, t

Re: Explicitly skip TAP tests under Meson if disabled

2023-10-31 Thread Tristan Partin
Hi Peter, You may find value in this Meson PR[0] adding a skip keyword argument to Meson's test() function. From what I understand of the PR and your issue, they seem related. If you could provide a comment describing why this is valuable to you, it would be good to help the Meson maintainers

Re: Explicitly skip TAP tests under Meson if disabled

2023-10-30 Thread Tom Lane
Aleksander Alekseev writes: > Personally I like the change. It makes the output more explicit. In my > use cases not running TAP tests typically is not something I want . So > I would appreciate being warned with a long list of bright yellow > "SKIP" messages. If I really want to skip TAP tests th

Re: Explicitly skip TAP tests under Meson if disabled

2023-10-30 Thread Aleksander Alekseev
Hi, > Under Meson, it is not very easy to see if TAP tests have been enabled > or disabled, if you rely on the default auto setting. You either need > to carefully study the meson setup output, or you notice, what a minute, > didn't there use to be like 250 tests, not only 80? > > I think it woul