On 2018-03-14 13:32:10 -0400, Tom Lane wrote:
> Andres Freund writes:
> > Only thing I wonder is if we shouldn't just *remove*
> > ExplainPropertyLong and make ExplainPropertyInteger accept 64bits of
> > input - the effort of passing and printing a 64bit integer will never be
> > relevant for expl
On 15 March 2018 at 05:07, Andres Freund wrote:
> On 2018-03-14 14:34:38 +1300, David Rowley wrote:
>> It would be nice to see us completely get rid of all the
>> appendStringInfo* calls, apart from in the functions which meant to
>> handle the behaviour specific to the explain format. This is a s
Hi,
On 2018-03-13 17:27:40 -0700, Andres Freund wrote:
> while adding EXPLAIN support for JITing (displaying time spent etc), I
> got annoyed by the amount of duplication required. There's a fair amount
> of
> if (es->format == EXPLAIN_FORMAT_TEXT)
> appendStringInfo(es->str, "Executio
Andres Freund writes:
> On 2018-03-14 13:32:10 -0400, Tom Lane wrote:
>> Andres Freund writes:
>>> Only thing I wonder is if we shouldn't just *remove*
>>> ExplainPropertyLong and make ExplainPropertyInteger accept 64bits of
>>> input - the effort of passing and printing a 64bit integer will neve
Hi,
On 2018-03-14 13:32:10 -0400, Tom Lane wrote:
> Andres Freund writes:
> > If we do this, and I think we should, I'm inclined to also commit a
> > patch that renames ExplainPropertyLong
> > and changes its argument type. Because passing long is just plain
> > unhelpful for 32bit platforms and
Andres Freund writes:
> If we do this, and I think we should, I'm inclined to also commit a
> patch that renames ExplainPropertyLong
> and changes its argument type. Because passing long is just plain
> unhelpful for 32bit platforms and windows. We should just always use
> 64bits here.
+1 --- I'
Hi,
On 2018-03-13 17:27:40 -0700, Andres Freund wrote:
> Hi,
>
> while adding EXPLAIN support for JITing (displaying time spent etc), I
> got annoyed by the amount of duplication required. There's a fair amount
> of
> if (es->format == EXPLAIN_FORMAT_TEXT)
> appendStringInfo(es->str,
Hi,
On 2018-03-14 14:34:38 +1300, David Rowley wrote:
> On 14 March 2018 at 13:27, Andres Freund wrote:
> > In the attached *POC* patch I've added a 'unit' parameter to the numeric
> > ExplainProperty* functions, which EXPLAIN_FORMAT_TEXT adds to the
> > output. This can avoid the above and othe
On 14 March 2018 at 13:27, Andres Freund wrote:
> In the attached *POC* patch I've added a 'unit' parameter to the numeric
> ExplainProperty* functions, which EXPLAIN_FORMAT_TEXT adds to the
> output. This can avoid the above and other similar branches (of which
> the JIT patch would add a number
