Re: Event trigger bugs (was Re: Repeated crashes in GENERATED ... AS IDENTITY tests)

2018-04-20 Thread Tom Lane
I wrote: > Hence, two questions: > * Should EventTriggerTableRewrite do > if (!currentEventTriggerState || > currentEventTriggerState->commandCollectionInhibited) > return; > like most of the other functions, or should it just check for null > currentEventTriggerState? After cl

Re: Event trigger bugs (was Re: Repeated crashes in GENERATED ... AS IDENTITY tests)

2018-04-19 Thread Alvaro Herrera
Tom Lane wrote: > Hence, two questions: > > * Should EventTriggerTableRewrite do > > if (!currentEventTriggerState || > currentEventTriggerState->commandCollectionInhibited) > return; > > like most of the other functions, or should it just check for null > currentEventTrigge