Re: Ensure that maxlen is an integer value in dict_int configuration

2018-03-27 Thread Daniel Gustafsson
> On 27 Mar 2018, at 15:04, Arthur Zakirov wrote: > But the patch breaks options parsing in another place. After the patch: > So the right fix could be as it done in postgres_fdw_validator() for > 'fetch_size' option. Doh. I had a strtol() first but found the defGetInt32() version elegantly sm

Re: Ensure that maxlen is an integer value in dict_int configuration

2018-03-27 Thread Arthur Zakirov
On Tue, Mar 27, 2018 at 01:17:20PM +0200, Daniel Gustafsson wrote: > I recently had a usecase for dict_int, typoed my script and spent longer than > I’d like to admit finding said typo. The attached patch scratches my itch by > ensuring that the maxlen parameter to dict_int is integer, instead of