Re: Documentation patch for ALTER SUBSCRIPTION

2020-02-05 Thread Alvaro Herrera
OK, pushed that. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Documentation patch for ALTER SUBSCRIPTION

2020-02-05 Thread David Christensen
> On Feb 5, 2020, at 7:56 AM, Alvaro Herrera wrote: > > On 2020-Feb-05, Amit Kapila wrote: > >> It is possible that one might not understand how this option works by >> reading the already existing text in docs, but I think writing in a >> different language the same thing also doesn't seem advi

Re: Documentation patch for ALTER SUBSCRIPTION

2020-02-05 Thread Alvaro Herrera
On 2020-Feb-05, Amit Kapila wrote: > It is possible that one might not understand how this option works by > reading the already existing text in docs, but I think writing in a > different language the same thing also doesn't seem advisable. I > think if we want to explain it better, then maybe a

Re: Documentation patch for ALTER SUBSCRIPTION

2020-02-05 Thread Amit Kapila
On Wed, Feb 5, 2020 at 8:44 AM David Christensen wrote: > > >> On Feb 4, 2020, at 8:45 PM, Amit Kapila wrote: > >> > >> On Fri, Jan 24, 2020 at 2:05 AM David Christensen > >> wrote: > >> Greetings, > >> Enclosed find a documentation patch that clarifies the behavior of ALTER > >> SUBSCRIPTION

Re: Documentation patch for ALTER SUBSCRIPTION

2020-02-04 Thread David Christensen
>> On Feb 4, 2020, at 8:45 PM, Amit Kapila wrote: >> >> On Fri, Jan 24, 2020 at 2:05 AM David Christensen >> wrote: >> Greetings, >> Enclosed find a documentation patch that clarifies the behavior of ALTER >> SUBSCRIPTION … REFRESH PUBLICATION with new tables; I ran into a situation >> tod

Re: Documentation patch for ALTER SUBSCRIPTION

2020-02-04 Thread Amit Kapila
On Fri, Jan 24, 2020 at 2:05 AM David Christensen wrote: > > Greetings, > > Enclosed find a documentation patch that clarifies the behavior of ALTER > SUBSCRIPTION … REFRESH PUBLICATION with new tables; I ran into a situation > today where the docs were not clear that existing tables would not b