Ahmed,
Thank you for the review.
I'm a bit confused by the reports of apply and compile errors. I didn't
touch anything involving "varlist" and see no errors then or now in my
Meson ninja build. Nor does the CI report any.
On Fri, Feb 14, 2025 at 2:01 PM Ahmed Ashour wrote:
> Feedback:
> ---
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation:tested, failed
Summary:
-
The patch adds documentation to clarify ho
On Wed, Jan 1, 2025 at 11:16 PM Gurjeet Singh wrote:
> > On Fri, Dec 20, 2024 at 9:02 AM David G. Johnston <
> david.g.johns...@gmail.com> wrote:
>
> >> The commit reference page lacks an "Outputs" section even though it is
> capable of outputting both "COMMIT" and "ROLLBACK".
>
> I generally agr
On Tue, Dec 31, 2024 at 12:50 PM David G. Johnston
wrote:
>
> Thoughts?
>
> On Fri, Dec 20, 2024 at 9:02 AM David G. Johnston
> wrote:
>>
>> Hi,
>>
>> The commit reference page lacks an "Outputs" section even though it is
>> capable of outputting both "COMMIT" and "ROLLBACK".
>>
>> The attached
Thoughts?
On Fri, Dec 20, 2024 at 9:02 AM David G. Johnston <
david.g.johns...@gmail.com> wrote:
> Hi,
>
> The commit reference page lacks an "Outputs" section even though it is
> capable of outputting both "COMMIT" and "ROLLBACK".
>
> The attached adds this section, describes when each applies,