Re: Doc chapter for Hash Indexes

2021-07-05 Thread Amit Kapila
On Tue, Jun 29, 2021 at 2:21 PM Amit Kapila wrote: > > On Sat, Jun 26, 2021 at 3:43 PM Amit Kapila wrote: > > > > I am planning to go through the patch once again and would like to > commit and backpatch till v10 in a day to two unless someone thinks > otherwise. > Pushed. -- With Regards, Ami

Re: Doc chapter for Hash Indexes

2021-06-29 Thread Amit Kapila
On Sat, Jun 26, 2021 at 3:43 PM Amit Kapila wrote: > > On Fri, Jun 25, 2021 at 3:11 PM Simon Riggs > wrote: > > > > On Fri, Jun 25, 2021 at 4:17 AM Amit Kapila wrote: > > > > > > On Fri, Jun 25, 2021 at 1:29 AM Bruce Momjian wrote: > > > > > > > > aOn Wed, Jun 23, 2021 at 12:56:51PM +0100, Simo

Re: Doc chapter for Hash Indexes

2021-06-26 Thread Amit Kapila
On Fri, Jun 25, 2021 at 3:11 PM Simon Riggs wrote: > > On Fri, Jun 25, 2021 at 4:17 AM Amit Kapila wrote: > > > > On Fri, Jun 25, 2021 at 1:29 AM Bruce Momjian wrote: > > > > > > aOn Wed, Jun 23, 2021 at 12:56:51PM +0100, Simon Riggs wrote: > > > > On Wed, Jun 23, 2021 at 5:12 AM Amit Kapila >

Re: Doc chapter for Hash Indexes

2021-06-25 Thread Simon Riggs
On Fri, Jun 25, 2021 at 4:17 AM Amit Kapila wrote: > > On Fri, Jun 25, 2021 at 1:29 AM Bruce Momjian wrote: > > > > aOn Wed, Jun 23, 2021 at 12:56:51PM +0100, Simon Riggs wrote: > > > On Wed, Jun 23, 2021 at 5:12 AM Amit Kapila > > > wrote: > > > > > > > > On Tue, Jun 22, 2021 at 2:31 PM Simon

Re: Doc chapter for Hash Indexes

2021-06-24 Thread Amit Kapila
On Fri, Jun 25, 2021 at 1:29 AM Bruce Momjian wrote: > > aOn Wed, Jun 23, 2021 at 12:56:51PM +0100, Simon Riggs wrote: > > On Wed, Jun 23, 2021 at 5:12 AM Amit Kapila wrote: > > > > > > On Tue, Jun 22, 2021 at 2:31 PM Simon Riggs > > > wrote: > > > > > > > > I attach both clean and compare versi

Re: Doc chapter for Hash Indexes

2021-06-24 Thread Bruce Momjian
aOn Wed, Jun 23, 2021 at 12:56:51PM +0100, Simon Riggs wrote: > On Wed, Jun 23, 2021 at 5:12 AM Amit Kapila wrote: > > > > On Tue, Jun 22, 2021 at 2:31 PM Simon Riggs > > wrote: > > > > > > I attach both clean and compare versions. > > > > > > > Do we want to hold this work for PG15 or commit in

Re: Doc chapter for Hash Indexes

2021-06-23 Thread Simon Riggs
On Wed, Jun 23, 2021 at 5:12 AM Amit Kapila wrote: > > On Tue, Jun 22, 2021 at 2:31 PM Simon Riggs > wrote: > > > > I attach both clean and compare versions. > > > > Do we want to hold this work for PG15 or commit in PG14 and backpatch > it till v10 where we have made hash indexes crash-safe? I w

Re: Doc chapter for Hash Indexes

2021-06-22 Thread Amit Kapila
On Tue, Jun 22, 2021 at 2:31 PM Simon Riggs wrote: > > I attach both clean and compare versions. > Do we want to hold this work for PG15 or commit in PG14 and backpatch it till v10 where we have made hash indexes crash-safe? I would vote for committing in PG14 and backpatch it till v10, however,

Re: Doc chapter for Hash Indexes

2021-06-22 Thread Simon Riggs
On Tue, Jun 22, 2021 at 7:15 AM Amit Kapila wrote: > > On Mon, Jun 21, 2021 at 6:38 PM Simon Riggs > wrote: > > > > New chapter for Hash Indexes, designed to help users understand how > > they work and when to use them. > > > > Mostly newly written, but a few paras lifted from README when they we

Re: Doc chapter for Hash Indexes

2021-06-21 Thread Amit Kapila
On Mon, Jun 21, 2021 at 6:38 PM Simon Riggs wrote: > > New chapter for Hash Indexes, designed to help users understand how > they work and when to use them. > > Mostly newly written, but a few paras lifted from README when they were > helpful. > Few comments == 1. + Hash indexes are

Re: Doc chapter for Hash Indexes

2021-06-21 Thread Amit Kapila
On Tue, Jun 22, 2021 at 4:25 AM Justin Pryzby wrote: > > On Mon, Jun 21, 2021 at 02:08:12PM +0100, Simon Riggs wrote: > > New chapter for Hash Indexes, designed to help users understand how > > they work and when to use them. > > > > Mostly newly written, but a few paras lifted from README when th

Re: Doc chapter for Hash Indexes

2021-06-21 Thread Justin Pryzby
On Mon, Jun 21, 2021 at 02:08:12PM +0100, Simon Riggs wrote: > New chapter for Hash Indexes, designed to help users understand how > they work and when to use them. > > Mostly newly written, but a few paras lifted from README when they were > helpful. + + PostgreSQL includes an implementation