Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-04-09 Thread Alvaro Herrera
On 2023-Apr-09, Noah Misch wrote: > On Thu, Mar 30, 2023 at 01:27:05AM -0500, Karl O. Pinc wrote: > > Your point seems valid but this is above my station. > > I have no idea as to how to best resolve this, or even how to make the > > resolution happen now that the change has been committed. > >

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-04-09 Thread Noah Misch
On Thu, Mar 30, 2023 at 01:27:05AM -0500, Karl O. Pinc wrote: > On Wed, 29 Mar 2023 21:32:05 -0700 > Noah Misch wrote: > > > On Sun, Jan 22, 2023 at 02:42:46PM -0600, Karl O. Pinc wrote: > > > v10-0001-List-trusted-and-obsolete-extensions.patch > > > > > + > > > + These modules and extensio

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-03-29 Thread Karl O. Pinc
On Wed, 29 Mar 2023 21:32:05 -0700 Noah Misch wrote: > On Sun, Jan 22, 2023 at 02:42:46PM -0600, Karl O. Pinc wrote: > > v10-0001-List-trusted-and-obsolete-extensions.patch > > > + > > + These modules and extensions are obsolete: > > + > > + > > + > > + > > + > > + > > C

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-03-29 Thread Noah Misch
On Sun, Jan 22, 2023 at 02:42:46PM -0600, Karl O. Pinc wrote: > v10-0001-List-trusted-and-obsolete-extensions.patch > + > + These modules and extensions are obsolete: > + > + > + > + > + > + Commit a013738 incorporated this change. Since xml2 is the only in-tree way to use XS

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-03-11 Thread Karl O. Pinc
Hi Alvaro, On Thu, 9 Mar 2023 10:22:49 +0100 Alvaro Herrera wrote: > On 2023-Jan-22, Karl O. Pinc wrote: > > > Actually, this CSS, added to doc/src/sgml/stylesheet.css, > > makes the column spacing look pretty good: > Okay, this looks good to me too. However, for it to actually work, we > need

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-03-09 Thread Alvaro Herrera
On 2023-Jan-22, Karl O. Pinc wrote: > Actually, this CSS, added to doc/src/sgml/stylesheet.css, > makes the column spacing look pretty good: > > /* Adequate spacing between columns in a simplelist non-inline table */ > .simplelist td { padding-left: 2em; padding-right: 2em; } Okay, this looks go

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-22 Thread Karl O. Pinc
On Sun, 22 Jan 2023 14:42:46 -0600 "Karl O. Pinc" wrote: > Attached are 2 patches: > > v10-0001-List-trusted-and-obsolete-extensions.patch > > List trusted extenions in 4 columns, with the CSS altered > to put spacing between vertical columns. In theory, a number of other simplelist presentati

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-22 Thread Karl O. Pinc
On Sun, 22 Jan 2023 08:09:03 -0600 "Karl O. Pinc" wrote: > On Sat, 21 Jan 2023 08:11:43 -0600 > "Karl O. Pinc" wrote: > > > Attached are 2 v9 patch versions. I don't think I like them. > > I think the v8 versions are better. But I thought it > > wouldn't hurt to show them to you. > > > > On

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-22 Thread Karl O. Pinc
On Sat, 21 Jan 2023 08:11:43 -0600 "Karl O. Pinc" wrote: > Attached are 2 v9 patch versions. I don't think I like them. > I think the v8 versions are better. But I thought it > wouldn't hurt to show them to you. > > On Fri, 20 Jan 2023 14:22:25 -0600 > "Karl O. Pinc" wrote: > > > Attached ar

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-21 Thread Karl O. Pinc
Attached are 2 v9 patch versions. I don't think I like them. I think the v8 versions are better. But I thought it wouldn't hurt to show them to you. On Fri, 20 Jan 2023 14:22:25 -0600 "Karl O. Pinc" wrote: > Attached are 2 alternatives: > (They touch separate files so the ordering is meaningle

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-20 Thread Karl O. Pinc
On Fri, 20 Jan 2023 14:22:25 -0600 "Karl O. Pinc" wrote: > v8-0001-List-trusted-and-obsolete-extensions.patch > > Instead of putting [trusted] and [obsolete] in the titles > of the modules, like v7 does, add a list of them into the text. The list is inline. It might be worthwhile experimenting

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-20 Thread Karl O. Pinc
On Fri, 20 Jan 2023 20:12:38 +0100 Alvaro Herrera wrote: > Ah, I wanted to attach the two remaining patches and forgot. Attached are 2 alternatives: (They touch separate files so the ordering is meaningless.) v8-0001-List-trusted-and-obsolete-extensions.patch Instead of putting [trusted] and

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-20 Thread Karl O. Pinc
On Fri, 20 Jan 2023 20:12:03 +0100 Alvaro Herrera wrote: > On 2023-Jan-20, Karl O. Pinc wrote: > > > On Fri, 20 Jan 2023 12:42:31 +0100 > > Alvaro Herrera wrote: > > > > Hmm, I didn't know that. I guess I can put it back. My own > > > instinct is to put the most important stuff first, not

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-20 Thread Alvaro Herrera
Ah, I wanted to attach the two remaining patches and forgot. Here they are. -- Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/ >From ba972984da37b5a315bd7a4face064d24ca41436 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Fri, 20 Jan 2023 12:32:22 +0100 Subject

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-20 Thread Alvaro Herrera
On 2023-Jan-20, Karl O. Pinc wrote: > On Fri, 20 Jan 2023 12:42:31 +0100 > Alvaro Herrera wrote: > > Hmm, I didn't know that. I guess I can put it back. My own instinct > > is to put the most important stuff first, not last, but if research > > says to do otherwise, fine, let's do that. > > A

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-20 Thread Karl O. Pinc
On Fri, 20 Jan 2023 12:42:31 +0100 Alvaro Herrera wrote: > On 2023-Jan-19, Karl O. Pinc wrote: > > > On Thu, 19 Jan 2023 11:03:53 -0600 > > "Karl O. Pinc" wrote: > > > > > Attached are 2 patches, a regular and a delta from your v4 review: > > > > > > contrib_v5-delta.patch.txt > > > contrib

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-20 Thread Alvaro Herrera
On 2023-Jan-19, Karl O. Pinc wrote: > On Thu, 19 Jan 2023 11:03:53 -0600 > "Karl O. Pinc" wrote: > > > Attached are 2 patches, a regular and a delta from your v4 review: > > > > contrib_v5-delta.patch.txt > > contrib_v5.patch.txt > > I left your appendix title unchanged: "Additional Supplied

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-19 Thread Karl O. Pinc
On Thu, 19 Jan 2023 11:03:53 -0600 "Karl O. Pinc" wrote: > Attached are 2 patches, a regular and a delta from your v4 review: > > contrib_v5-delta.patch.txt > contrib_v5.patch.txt I left your appendix title unchanged: "Additional Supplied Extensions and Modules". I had put "Extensions" afte

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-19 Thread Karl O. Pinc
On Thu, 19 Jan 2023 13:35:17 +0100 Alvaro Herrera wrote: > On 2023-Jan-18, Karl O. Pinc wrote: > > > Oops. Already sent a revised patch that includes starting each > > module on a new page, for PDF output. I'll wait to rip that > > out after review and start a new thread if necessary. (I have

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-19 Thread Alvaro Herrera
On 2023-Jan-18, Karl O. Pinc wrote: > Oops. Already sent a revised patch that includes starting each > module on a new page, for PDF output. I'll wait to rip that > out after review and start a new thread if necessary. Here's my review in the form of a delta patch. I didn't find that a thing

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-18 Thread Karl O. Pinc
On Wed, 18 Jan 2023 18:34:47 +0100 Alvaro Herrera wrote: > On 2023-Jan-18, Karl O. Pinc wrote: > > > On Wed, 18 Jan 2023 13:30:45 +0100 > > Alvaro Herrera wrote: > > > > > Not related to this patch: it's very annoying that in the PDF > > > output, each section in the appendix doesn't start o

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-18 Thread Karl O. Pinc
On Wed, 18 Jan 2023 13:25:57 +0100 Alvaro Herrera wrote: > On 2023-Jan-02, Karl O. Pinc wrote: > > Attached is a patch: contrib_v1.patch > > > > It modifies Appendix F, the contrib directory. > > > > It adds brief text into the titles shown in the > > table of contents so it's easier to tell w

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-18 Thread Alvaro Herrera
On 2023-Jan-18, Karl O. Pinc wrote: > On Wed, 18 Jan 2023 13:30:45 +0100 > Alvaro Herrera wrote: > > > Not related to this patch: it's very annoying that in the PDF output, > > each section in the appendix doesn't start on a blank page -- which > > means that the doc page for many modules starts

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-18 Thread Karl O. Pinc
On Wed, 18 Jan 2023 13:30:45 +0100 Alvaro Herrera wrote: > Not related to this patch: it's very annoying that in the PDF output, > each section in the appendix doesn't start on a blank page -- which > means that the doc page for many modules starts in the middle of a > page were the previous one

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-18 Thread Alvaro Herrera
Not related to this patch: it's very annoying that in the PDF output, each section in the appendix doesn't start on a blank page -- which means that the doc page for many modules starts in the middle of a page were the previous one ends. This is very ugly. And then you get to dblink, which contai

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-18 Thread Alvaro Herrera
On 2023-Jan-02, Karl O. Pinc wrote: > Hi, > > Attached is a patch: contrib_v1.patch > > It modifies Appendix F, the contrib directory. > > It adds brief text into the titles shown in the > table of contents so it's easier to tell what > each module does. It also suffixes [trusted] or [obsolete

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-15 Thread Karl O. Pinc
On Sun, 15 Jan 2023 07:11:30 +0100 Brar Piening wrote: > On 03.01.2023 at 01:00, Karl O. Pinc wrote: > > Attached is a patch: contrib_v1.patch > > > > It modifies Appendix F, the contrib directory. > > Review: > It adds a brief explanatory part to the headers of all contrib modules > The exp

Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

2023-01-14 Thread Brar Piening
On 03.01.2023 at 01:00, Karl O. Pinc wrote: Attached is a patch: contrib_v1.patch It modifies Appendix F, the contrib directory. Review: The patch applies cleanly (1334b79a35 - 2023-01-14 18:05:09 +0900). It adds a brief explanatory part to the headers of all contrib modules which I consider