On Thu, Sep 12, 2024 at 4:24 PM Amit Kapila wrote:
>
> On Wed, Sep 11, 2024 at 8:41 AM shveta malik wrote:
> >
> > On Tue, Sep 10, 2024 at 11:24 PM Bharath Rupireddy
> > wrote:
> > >
> > >
> > > Please find the attached v2 patch also having Shveta's review comments
> > > addressed.
> >
> > The v
On Wed, Sep 11, 2024 at 8:41 AM shveta malik wrote:
>
> On Tue, Sep 10, 2024 at 11:24 PM Bharath Rupireddy
> wrote:
> >
> >
> > Please find the attached v2 patch also having Shveta's review comments
> > addressed.
>
> The v2 patch looks good to me.
>
LGTM as well. I'll push this tomorrow morning
On Tue, Sep 10, 2024 at 11:24 PM Bharath Rupireddy
wrote:
>
>
> Please find the attached v2 patch also having Shveta's review comments
> addressed.
The v2 patch looks good to me.
thanks
Shveta
On Wed, Sep 11, 2024 at 3:54 AM Bharath Rupireddy
wrote:
>
> Hi,
>
> Thanks for reviewing.
>
> On Tue, Sep 10, 2024 at 8:40 AM Peter Smith wrote:
> >
> > Commit message
> >
> > 1.
> > ALTER_REPLICATION_SLOT on invalidated replication slots is unnecessary
> > as there is no way...
> >
> > suggesti
Hi,
Thanks for reviewing.
On Tue, Sep 10, 2024 at 8:40 AM Peter Smith wrote:
>
> Commit message
>
> 1.
> ALTER_REPLICATION_SLOT on invalidated replication slots is unnecessary
> as there is no way...
>
> suggestion:
> ALTER_REPLICATION_SLOT for invalid replication slots should not be
> allowed b
On Tue, Sep 10, 2024 at 8:40 AM Peter Smith wrote:
>
> Hi, here are some review comments for patch v1.
>
> ==
> Commit message
>
> 1.
> ALTER_REPLICATION_SLOT on invalidated replication slots is unnecessary
> as there is no way...
>
> suggestion:
> ALTER_REPLICATION_SLOT for invalid replicatio
On Tue, Sep 10, 2024 at 12:11 AM Bharath Rupireddy
wrote:
>
> Hi,
>
> ALTER_REPLICATION_SLOT on invalidated replication slots is unnecessary
> as there is no way to get the invalidated (logical) slot to work.
> Please find the patch to add an error in such cases. Relevant
> discussion is at [1].
>
Hi, here are some review comments for patch v1.
==
Commit message
1.
ALTER_REPLICATION_SLOT on invalidated replication slots is unnecessary
as there is no way...
suggestion:
ALTER_REPLICATION_SLOT for invalid replication slots should not be
allowed because there is no way...
==
2. Missi
