Re: Defaulting to jit=on/off for v11

2018-09-15 Thread Andres Freund
Hi, On 2018-09-15 11:41:58 -0700, Andres Freund wrote: > I'll email the folks that have LLVM enabled in the BF, to also do so. Done so. I'll try to check-in again tonight, but while likely, it's not certain there'll be reception. - Andres

Re: Defaulting to jit=on/off for v11

2018-09-15 Thread Andres Freund
On 2018-09-15 14:19:55 -0400, Tom Lane wrote: > Andres Freund writes: > > On September 15, 2018 12:14:07 PM MDT, Tom Lane wrote: > >> Is there more that has to be done than switching the GUC's default > >> value and adjusting docs? I could probably make it happen if there's > >> not any hidden s

Re: Defaulting to jit=on/off for v11

2018-09-15 Thread Tom Lane
Andres Freund writes: > On September 15, 2018 12:14:07 PM MDT, Tom Lane wrote: >> Is there more that has to be done than switching the GUC's default >> value and adjusting docs? I could probably make it happen if there's >> not any hidden stuff to worry about. > No, that should be all. I'll ad

Re: Defaulting to jit=on/off for v11

2018-09-15 Thread Andres Freund
Hi, On September 15, 2018 12:14:07 PM MDT, Tom Lane wrote: >Andres Freund writes: >> Cool, sounds we have agreement. I'll try to come up with a patch. >I'm [un]fortunately hiking till Wednesday, so I won't have an easy time >to push a patch. I probably could push something tomorrow, but I'

Re: Defaulting to jit=on/off for v11

2018-09-15 Thread Tom Lane
Andres Freund writes: > Cool, sounds we have agreement. I'll try to come up with a patch. I'm > [un]fortunately hiking till Wednesday, so I won't have an easy time to push a > patch. I probably could push something tomorrow, but I'd have a hard time > cleaning up if needed. Does anybody fee

Re: Defaulting to jit=on/off for v11

2018-09-15 Thread Andres Freund
On September 15, 2018 8:26:17 AM MDT, Andrew Dunstan wrote: > > >On 09/14/2018 08:18 PM, Peter Geoghegan wrote: >> On Fri, Sep 14, 2018 at 3:32 PM, Tom Lane wrote: >>> I'd go with #2, personally. It does seem that the costing needs >work, >>> but it's not clear to me that we know what to cha

Re: Defaulting to jit=on/off for v11

2018-09-15 Thread Andrew Dunstan
On 09/14/2018 08:18 PM, Peter Geoghegan wrote: On Fri, Sep 14, 2018 at 3:32 PM, Tom Lane wrote: I'd go with #2, personally. It does seem that the costing needs work, but it's not clear to me that we know what to change, so it's kinda late to propose #3 for v11. +1. I also favor option #2.

Re: Defaulting to jit=on/off for v11

2018-09-14 Thread Peter Geoghegan
On Fri, Sep 14, 2018 at 3:32 PM, Tom Lane wrote: > I'd go with #2, personally. It does seem that the costing needs work, > but it's not clear to me that we know what to change, so it's kinda > late to propose #3 for v11. +1. I also favor option #2. -- Peter Geoghegan

Re: Defaulting to jit=on/off for v11

2018-09-14 Thread Jonathan S. Katz
On 9/14/18 6:32 PM, Tom Lane wrote: > Andres Freund writes: >> I can see basically three sensible routes to go for v11 (before we >> improve further): > >> 1) Leave it enabled, as currently. > >> 2) Disable it by default in v11, leave it enabled in master. > >> 3) Increase the costs substantial

Re: Defaulting to jit=on/off for v11

2018-09-14 Thread Tom Lane
Andres Freund writes: > I can see basically three sensible routes to go for v11 (before we > improve further): > 1) Leave it enabled, as currently. > 2) Disable it by default in v11, leave it enabled in master. > 3) Increase the costs substantially, so it triggers in far fewer >cases. Those