Re: Dead encoding conversion functions

2019-06-30 Thread Tom Lane
Peter Eisentraut writes: > On 2019-05-29 21:03, Tom Lane wrote: >> If we do delete them as useless, it might also be advisable to change >> CreateConversionCommand() to refuse creation of conversions to/from >> SQL_ASCII, to prevent future confusion. > It seems nonsensical by definition to allow

Re: Dead encoding conversion functions

2019-06-25 Thread Peter Eisentraut
On 2019-05-29 21:03, Tom Lane wrote: > If we do delete them as useless, it might also be advisable to change > CreateConversionCommand() to refuse creation of conversions to/from > SQL_ASCII, to prevent future confusion. It seems nonsensical by definition to allow that. -- Peter Eisentraut

Re: Dead encoding conversion functions

2019-06-15 Thread Noah Misch
On Wed, May 29, 2019 at 03:03:13PM -0400, Tom Lane wrote: > Pursuant to today's discussion at PGCon about code coverage, I went > nosing into some of the particularly under-covered subdirectories > in our tree, and immediately tripped over an interesting factoid: > the ASCII<->MIC and ASCII<->UTF8

Re: Dead encoding conversion functions

2019-05-29 Thread Daniel Gustafsson
> On 29 May 2019, at 15:03, Tom Lane wrote: > > Pursuant to today's discussion at PGCon about code coverage, I went > nosing into some of the particularly under-covered subdirectories > in our tree, On a similar, but much less important/interesting note. I fat-fingered when compiling isolationt