Re: Dead code in adminpack

2020-02-13 Thread Michael Paquier
On Thu, Feb 13, 2020 at 12:41:46PM +0100, Julien Rouhaud wrote: > On Thu, Feb 13, 2020 at 12:14 PM Antonin Houska wrote: >> I've noticed that convert_and_check_filename() is always passed false for the >> "logAllowed" argument - someone probably forgot to remove the argument when >> it >> was dec

Re: Dead code in adminpack

2020-02-13 Thread Michael Paquier
On Thu, Feb 13, 2020 at 12:15:39PM +0100, Antonin Houska wrote: > I've noticed that convert_and_check_filename() is always passed false for the > "logAllowed" argument - someone probably forgot to remove the argument when it > was decided that log files are no longer accepted. If the argument was

Re: Dead code in adminpack

2020-02-13 Thread Julien Rouhaud
On Thu, Feb 13, 2020 at 12:14 PM Antonin Houska wrote: > > I've noticed that convert_and_check_filename() is always passed false for the > "logAllowed" argument - someone probably forgot to remove the argument when it > was decided that log files are no longer accepted. If the argument was > remo