Re: Correct error message for end-of-recovery record TLI

2022-01-25 Thread Bossart, Nathan
On 1/24/22, 8:42 PM, "Amul Sul" wrote: > On Tue, Jan 25, 2022 at 10:08 AM Michael Paquier wrote: >> >> On Wed, Dec 01, 2021 at 07:09:34PM +, Bossart, Nathan wrote: >> > The patch no longer applied, so I went ahead and rebased it. >> >> This was on the CF stack for some time, so applied. I ha

Re: Correct error message for end-of-recovery record TLI

2022-01-24 Thread Amul Sul
On Tue, Jan 25, 2022 at 10:08 AM Michael Paquier wrote: > > On Wed, Dec 01, 2021 at 07:09:34PM +, Bossart, Nathan wrote: > > The patch no longer applied, so I went ahead and rebased it. > > This was on the CF stack for some time, so applied. I have also > changed the messages produced for the

Re: Correct error message for end-of-recovery record TLI

2022-01-24 Thread Michael Paquier
On Wed, Dec 01, 2021 at 07:09:34PM +, Bossart, Nathan wrote: > The patch no longer applied, so I went ahead and rebased it. This was on the CF stack for some time, so applied. I have also changed the messages produced for the shutdown and online checkpoint records as they used the same messag

Re: Correct error message for end-of-recovery record TLI

2021-10-28 Thread Amul Sul
On Fri, Oct 29, 2021 at 2:36 AM Robert Haas wrote: > > On Thu, Oct 28, 2021 at 3:52 PM Bossart, Nathan wrote: > > When I apply the patch, it changes the PANIC message in the > > XLOG_CHECKPOINT_ONLINE section, not the XLOG_END_OF_RECOVERY one. > > Well that's a good point. *facepalm* > Oops... :

Re: Correct error message for end-of-recovery record TLI

2021-10-28 Thread Robert Haas
On Thu, Oct 28, 2021 at 3:52 PM Bossart, Nathan wrote: > When I apply the patch, it changes the PANIC message in the > XLOG_CHECKPOINT_ONLINE section, not the XLOG_END_OF_RECOVERY one. Well that's a good point. *facepalm* -- Robert Haas EDB: http://www.enterprisedb.com

Re: Correct error message for end-of-recovery record TLI

2021-10-28 Thread Bossart, Nathan
On 10/28/21, 12:52 PM, "Bossart, Nathan" wrote: > On 10/28/21, 12:23 PM, "Robert Haas" wrote: >> On Thu, Oct 28, 2021 at 8:59 AM Amul Sul wrote: >>> In xlog_redo, for end-of-recovery case error message describes the >>> record as a checkpoint record which seems to be incorrect; the >>> attached

Re: Correct error message for end-of-recovery record TLI

2021-10-28 Thread Bossart, Nathan
On 10/28/21, 12:23 PM, "Robert Haas" wrote: > On Thu, Oct 28, 2021 at 8:59 AM Amul Sul wrote: >> In xlog_redo, for end-of-recovery case error message describes the >> record as a checkpoint record which seems to be incorrect; the >> attached patch corrects that. > > The analysis and patch appear

Re: Correct error message for end-of-recovery record TLI

2021-10-28 Thread Robert Haas
On Thu, Oct 28, 2021 at 8:59 AM Amul Sul wrote: > In xlog_redo, for end-of-recovery case error message describes the > record as a checkpoint record which seems to be incorrect; the > attached patch corrects that. The analysis and patch appear correct to me. -- Robert Haas EDB: http://www.enter