Re: Convert node test compile-time settings into run-time parameters

2024-07-25 Thread Peter Eisentraut
On 24.05.24 16:39, Tom Lane wrote: Maybe not three settings, but a single setting, with multiple values, like debug_io_direct? Yeah, good idea. Let's get some more feedback on this before I code up a complicated list parser. Kinda doubt it's worth the trouble, either to code the GUC support or

Re: Convert node test compile-time settings into run-time parameters

2024-05-24 Thread Tom Lane
Peter Eisentraut writes: > Ok, I have an improved plan. I'm wrapping all the code related to this > in #ifdef DEBUG_NODE_TESTS_ENABLED. This in turn is defined in > assert-enabled builds, or if you define it explicitly, or if you define > one of the legacy individual symbols. That way you ge

Re: Convert node test compile-time settings into run-time parameters

2024-05-24 Thread Peter Eisentraut
On 21.05.24 20:48, Andres Freund wrote: Where I'd be more concerned about peformance is the added branch in READ_LOCATION_FIELD. There are a lot of calls to that, addding runtime branches to each, with external function calls inside, is somewhat likely to be measurable. Ok, I have an improved p

Re: Convert node test compile-time settings into run-time parameters

2024-05-21 Thread Andres Freund
Hi, On 2024-05-20 09:28:39 +0200, Peter Eisentraut wrote: > - Performance? Looking for example at pg_parse_query() and its siblings, > they also check for other debugging settings like log_parser_stats in the > main code path, so it doesn't seem to be a concern. I don't think we can conclude tha

Re: Convert node test compile-time settings into run-time parameters

2024-05-21 Thread Ranier Vilela
Em ter., 21 de mai. de 2024 às 09:25, Peter Eisentraut escreveu: > On 20.05.24 15:59, Tom Lane wrote: > > Peter Eisentraut writes: > >> This patch converts the compile-time settings > >> COPY_PARSE_PLAN_TREES > >> WRITE_READ_PARSE_PLAN_TREES > >> RAW_EXPRESSION_COVERAGE_TEST >

Re: Convert node test compile-time settings into run-time parameters

2024-05-21 Thread Peter Eisentraut
On 20.05.24 15:59, Tom Lane wrote: Peter Eisentraut writes: This patch converts the compile-time settings COPY_PARSE_PLAN_TREES WRITE_READ_PARSE_PLAN_TREES RAW_EXPRESSION_COVERAGE_TEST into run-time parameters debug_copy_parse_plan_trees debug_write_read_pars

Re: Convert node test compile-time settings into run-time parameters

2024-05-20 Thread Tom Lane
Peter Eisentraut writes: > This patch converts the compile-time settings > COPY_PARSE_PLAN_TREES > WRITE_READ_PARSE_PLAN_TREES > RAW_EXPRESSION_COVERAGE_TEST > into run-time parameters > debug_copy_parse_plan_trees > debug_write_read_parse_plan_trees > debug_raw_exp

Re: Convert node test compile-time settings into run-time parameters

2024-05-20 Thread Ranier Vilela
Em seg., 20 de mai. de 2024 às 04:28, Peter Eisentraut escreveu: > This patch converts the compile-time settings > > COPY_PARSE_PLAN_TREES > WRITE_READ_PARSE_PLAN_TREES > RAW_EXPRESSION_COVERAGE_TEST > > into run-time parameters > > debug_copy_parse_plan_trees > debug_wri