Re: Context diffs

2021-01-05 Thread Bruce Momjian
On Wed, Jan 6, 2021 at 10:21:22AM +1300, Thomas Munro wrote: > On Wed, Jan 6, 2021 at 6:58 AM Bruce Momjian wrote: > > On Tue, Jan 5, 2021 at 11:21:07AM +1300, Thomas Munro wrote: > > > For the record, cfbot just uses plain old GNU patch, because that > > > seems to accept nearly everything that

Re: Context diffs

2021-01-05 Thread Andrew Dunstan
On 1/5/21 12:58 PM, Bruce Momjian wrote: > On Tue, Jan 5, 2021 at 11:21:07AM +1300, Thomas Munro wrote: >> On Tue, Jan 5, 2021 at 8:07 AM Bruce Momjian wrote: >>> * "git apply" and "git am" can't process context diffs (they throw an >>>error once a context-like section of the diff is hit;

Re: Context diffs

2021-01-05 Thread Thomas Munro
On Wed, Jan 6, 2021 at 6:58 AM Bruce Momjian wrote: > On Tue, Jan 5, 2021 at 11:21:07AM +1300, Thomas Munro wrote: > > For the record, cfbot just uses plain old GNU patch, because that > > seems to accept nearly everything that anyone posts here (after a step > > that tries to unpack tarballs etc

Re: Context diffs

2021-01-05 Thread Bruce Momjian
On Tue, Jan 5, 2021 at 11:21:07AM +1300, Thomas Munro wrote: > On Tue, Jan 5, 2021 at 8:07 AM Bruce Momjian wrote: > > * "git apply" and "git am" can't process context diffs (they throw an > >error once a context-like section of the diff is hit; simple > >adding/removing lines in a block

Re: Context diffs

2021-01-05 Thread Bruce Momjian
On Mon, Jan 4, 2021 at 02:42:16PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > Our developer FAQ mentions context diffs in several places for their > > improved readability: > > https://wiki.postgresql.org/wiki/Developer_FAQ > > I think that's kind of out of date; AFAIK the majority of

Re: Context diffs

2021-01-05 Thread Andrew Dunstan
On 1/4/21 5:21 PM, Thomas Munro wrote: > On Tue, Jan 5, 2021 at 8:07 AM Bruce Momjian wrote: >> * "git apply" and "git am" can't process context diffs (they throw an >>error once a context-like section of the diff is hit; simple >>adding/removing lines in a block works) >> >> * the com

Re: Context diffs

2021-01-04 Thread Noah Misch
On Tue, Jan 05, 2021 at 11:21:07AM +1300, Thomas Munro wrote: > On Tue, Jan 5, 2021 at 8:07 AM Bruce Momjian wrote: > > * "git apply" and "git am" can't process context diffs (they throw an > >error once a context-like section of the diff is hit; simple > >adding/removing lines in a block

Re: Context diffs

2021-01-04 Thread Thomas Munro
On Tue, Jan 5, 2021 at 8:07 AM Bruce Momjian wrote: > * "git apply" and "git am" can't process context diffs (they throw an >error once a context-like section of the diff is hit; simple >adding/removing lines in a block works) > > * the commit-fest doesn't recognized context diff attachm

Re: Context diffs

2021-01-04 Thread Peter Geoghegan
On Mon, Jan 4, 2021 at 11:07 AM Bruce Momjian wrote: > * "git apply" and "git am" can't process context diffs (they throw an >error once a context-like section of the diff is hit; simple >adding/removing lines in a block works) I think that this is the big issue for me. I really find it

Re: Context diffs

2021-01-04 Thread Tom Lane
Bruce Momjian writes: > Our developer FAQ mentions context diffs in several places for their > improved readability: > https://wiki.postgresql.org/wiki/Developer_FAQ I think that's kind of out of date; AFAIK the majority of hackers think -u format is more readable. (For myself, I've gotten