Re: Consolidate ItemPointer to Datum conversion functions

2023-02-13 Thread Peter Eisentraut
On 09.02.23 09:33, Peter Eisentraut wrote: On 06.02.23 11:11, Heikki Linnakangas wrote: On 06/02/2023 11:54, Peter Eisentraut wrote: Instead of defining the same set of macros several times, define it once in an appropriate header file.  In passing, convert to inline functions. Looks good to

Re: Consolidate ItemPointer to Datum conversion functions

2023-02-09 Thread Peter Eisentraut
On 06.02.23 11:11, Heikki Linnakangas wrote: On 06/02/2023 11:54, Peter Eisentraut wrote: Instead of defining the same set of macros several times, define it once in an appropriate header file.  In passing, convert to inline functions. Looks good to me. Did you consider moving PG_GETARG_ITEMPO

Re: Consolidate ItemPointer to Datum conversion functions

2023-02-06 Thread Heikki Linnakangas
On 06/02/2023 11:54, Peter Eisentraut wrote: Instead of defining the same set of macros several times, define it once in an appropriate header file. In passing, convert to inline functions. Looks good to me. Did you consider moving PG_GETARG_ITEMPOINTER and PG_RETURN_ITEMPOINTER, too? They're