Re: Compiler warning on Debian 12, PostgreSQL 16 Beta3

2023-11-07 Thread Thomas Munro
On Wed, Nov 8, 2023 at 8:13 AM Alvaro Herrera wrote: > On 2023-Nov-08, Thomas Munro wrote: > > On Wed, Nov 8, 2023 at 4:46 AM Alvaro Herrera > > wrote: > > > On 2023-Aug-25, Daniel Westermann (DWE) wrote: > > > > > > Yeah, I get this one too. I thought commit 37d5babb5cfa ("jit: Support > > > o

Re: Compiler warning on Debian 12, PostgreSQL 16 Beta3

2023-11-07 Thread Alvaro Herrera
On 2023-Nov-08, Thomas Munro wrote: > On Wed, Nov 8, 2023 at 4:46 AM Alvaro Herrera wrote: > > On 2023-Aug-25, Daniel Westermann (DWE) wrote: > > > > Yeah, I get this one too. I thought commit 37d5babb5cfa ("jit: Support > > opaque pointers in LLVM 16.") was going to silence it, but I was quite

Re: Compiler warning on Debian 12, PostgreSQL 16 Beta3

2023-11-07 Thread Thomas Munro
On Wed, Nov 8, 2023 at 4:46 AM Alvaro Herrera wrote: > On 2023-Aug-25, Daniel Westermann (DWE) wrote: > > I've just noticed this warning when building on Debian 12: > > > > In file included from > > /usr/lib/llvm-14/include/llvm/Analysis/ModuleSummaryAnalysis.h:17, > > from llvmj

Re: Compiler warning on Debian 12, PostgreSQL 16 Beta3

2023-11-07 Thread Alvaro Herrera
On 2023-Aug-25, Daniel Westermann (DWE) wrote: > I've just noticed this warning when building on Debian 12: > > In file included from > /usr/lib/llvm-14/include/llvm/Analysis/ModuleSummaryAnalysis.h:17, > from llvmjit_inline.cpp:51: > /usr/lib/llvm-14/include/llvm/IR/ModuleSumma

Re: Compiler warning

2020-08-26 Thread Tom Lane
Bruce Momjian writes: > I see a compiler warning on git master: >sharedfileset.c:288:8: warning: variable ‘found’ set but not used > [-Wunused-but-set-variable] Could get rid of the variable entirely: change the "break" to "return" and then the final Assert can be "Assert(false)".

Re: compiler warning in pgcrypto imath.c

2019-05-04 Thread Jeff Janes
On Sat, May 4, 2019 at 3:15 AM Noah Misch wrote: > > I pushed Jeff's patch. > Thank you. I've re-tested it and I get warning-free compilation now. Cheers, Jeff

Re: compiler warning in pgcrypto imath.c

2019-05-04 Thread Michael Paquier
On Sat, May 04, 2019 at 12:15:19AM -0700, Noah Misch wrote: > I pushed Jeff's patch. Upon resolution, could you move the related open item on the wiki page to the list of resolved issues [1]? [1]: https://wiki.postgresql.org/wiki/PostgreSQL_12_Open_Items#resolved_before_12beta1 -- Michael sig

Re: compiler warning in pgcrypto imath.c

2019-05-04 Thread Noah Misch
On Wed, May 01, 2019 at 09:18:02AM -0700, Andres Freund wrote: > On 2019-03-23 00:02:36 -0700, Noah Misch wrote: > > On Sat, Mar 23, 2019 at 10:20:16AM +0900, Michael Paquier wrote: > > > On Fri, Mar 22, 2019 at 08:20:53PM -0400, Jeff Janes wrote: > > > > PostgreSQL 12devel on aarch64-unknown-linux

Re: compiler warning in pgcrypto imath.c

2019-05-01 Thread Andres Freund
Hi Noah, On 2019-03-23 00:02:36 -0700, Noah Misch wrote: > On Sat, Mar 23, 2019 at 10:20:16AM +0900, Michael Paquier wrote: > > On Fri, Mar 22, 2019 at 08:20:53PM -0400, Jeff Janes wrote: > > > PostgreSQL 12devel on aarch64-unknown-linux-gnu, compiled by gcc > > > (Ubuntu/Linaro 7.3.0-27ubuntu1~18

Re: compiler warning in pgcrypto imath.c

2019-03-23 Thread Noah Misch
On Sat, Mar 23, 2019 at 10:20:16AM +0900, Michael Paquier wrote: > On Fri, Mar 22, 2019 at 08:20:53PM -0400, Jeff Janes wrote: > > PostgreSQL 12devel on aarch64-unknown-linux-gnu, compiled by gcc > > (Ubuntu/Linaro 7.3.0-27ubuntu1~18.04) 7.3.0, 64-bit > > Adding Noah in CC as he has done the updat

Re: compiler warning in pgcrypto imath.c

2019-03-22 Thread Michael Paquier
On Fri, Mar 22, 2019 at 08:20:53PM -0400, Jeff Janes wrote: > PostgreSQL 12devel on aarch64-unknown-linux-gnu, compiled by gcc > (Ubuntu/Linaro 7.3.0-27ubuntu1~18.04) 7.3.0, 64-bit Adding Noah in CC as he has done the update of imath lately. > The attached patch adds PG_USED_FOR_ASSERTS_ONLY to s