Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-29 Thread Rémi Lapeyre
> > 2780: Allow COPY "text" to output a header and add header matching mode to > COPY > FROM > === > The original patch was rejected for lacking matching, but it has since been > addressed in an updated patch which has se

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-16 Thread Daniil Zakhlystov
Hi! It’s been a while since the original patch release. Let me provide a brief overview of the current patch status. The initial approach was to use the streaming compression to compress all outgoing and decompress all incoming bytes. However, after the long discussion in the thread, the initia

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-15 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Nov 15, 2021 at 2:51 PM Stephen Frost wrote: > > I get that just compressing the entire stream is simpler and easier and > > such, but it's surely cheaper and more efficient to not decompress and > > then recompress data that's alr

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-15 Thread Justin Pryzby
On Mon, Nov 15, 2021 at 03:23:17PM -0500, Robert Haas wrote: > On Mon, Nov 15, 2021 at 2:51 PM Stephen Frost wrote: > > I get that just compressing the entire stream is simpler and easier and > > such, but it's surely cheaper and more efficient to not decompress and > > then recompress data that's

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-15 Thread Robert Haas
On Mon, Nov 15, 2021 at 2:51 PM Stephen Frost wrote: > I get that just compressing the entire stream is simpler and easier and > such, but it's surely cheaper and more efficient to not decompress and > then recompress data that's already compressed. Finding a way to pass > through data that's alr

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-15 Thread Stephen Frost
Greetings, * Daniel Gustafsson (dan...@yesql.se) wrote: > > On 15 Nov 2021, at 15:32, Robert Haas wrote: > > On Tue, Nov 9, 2021 at 9:12 AM Daniel Gustafsson wrote: > >> 2773: libpq compression > >> === > >> This patch intended to provide libpq connection compression to "repl

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-15 Thread Daniel Gustafsson
> On 15 Nov 2021, at 15:32, Robert Haas wrote: > > On Tue, Nov 9, 2021 at 9:12 AM Daniel Gustafsson wrote: >> 2773: libpq compression >> === >> This patch intended to provide libpq connection compression to "replace SSL >> compression" which was doomed when the patch was writ

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-15 Thread Robert Haas
On Tue, Nov 9, 2021 at 9:12 AM Daniel Gustafsson wrote: > 2773: libpq compression > === > This patch intended to provide libpq connection compression to "replace SSL > compression" which was doomed when the patch was written, and have since been > removed altogether. The initi

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-14 Thread Tom Lane
Stephen Frost writes: > Attackers aren't likely to have the kind of isolated control over the > data in the WAL stream (which is a combination of data from lots of > ongoing activity in the system and isn't likely to be exactly what the > attacker supplied at some higher level anyway) and the abil

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-14 Thread Stephen Frost
Greetings, * Andrey Borodin (x4...@yandex-team.ru) wrote: > > On 11/10/21 16:54, Andrey Borodin wrote: > >> Compression is crucial for highly available setups. Replication traffic is > >> often billed. Or route has bandwidth limits. > >> An entropy added by WAL headers makes CRIME attack against

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-14 Thread Andrey Borodin
> On 11/10/21 16:54, Andrey Borodin wrote: > >> Compression is crucial for highly available setups. Replication traffic is >> often billed. Or route has bandwidth limits. >> An entropy added by WAL headers makes CRIME attack against replication >> encryption impractical. > > I very much doub

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-12 Thread Tomas Vondra
On 11/10/21 16:54, Andrey Borodin wrote: Daniel Gustafsson writes: 2773: libpq compression === This patch intended to provide libpq connection compression to "replace SSL compression" which was doomed when the patch was written, and have since been removed altogether. Th

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-12 Thread Tomas Vondra
On 11/10/21 00:21, Bruce Momjian wrote: On Tue, Nov 9, 2021 at 12:43:20PM -0500, Stephen Frost wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: Daniel Gustafsson writes: I'm not Robert, but I still have an opinion here, and that it's that this feature would at best be an attractive nuisance.

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-12 Thread Nikolay Samokhvalov
On Tue, Nov 9, 2021 at 7:02 AM Tom Lane wrote: > Daniel Gustafsson writes: > > 2773: libpq compression > > === > > This patch intended to provide libpq connection compression to "replace > SSL > > compression" which was doomed when the patch was written, and have since > been

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-12 Thread Daniel Gustafsson
> On 9 Nov 2021, at 18:43, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> Daniel Gustafsson writes: >>> 2773: libpq compression >>> === >>> This patch intended to provide libpq connection compression to "replace SSL >>> compression" which was doomed when the

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-10 Thread Andrey Borodin
> Daniel Gustafsson writes: > >> 2773: libpq compression >> === >> This patch intended to provide libpq connection compression to "replace SSL >> compression" which was doomed when the patch was written, and have since been >> removed altogether. The initial approach didn't

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-10 Thread Michael Paquier
On Tue, Nov 09, 2021 at 03:12:39PM +0100, Daniel Gustafsson wrote: > 2800: CLUSTER on partitioned table > == > The the patch above, it too spawned off from the REINDEX CONCURRENTLY thread > but seems to have stalled awaiting more review. There was scepticism raised

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-09 Thread Bruce Momjian
On Tue, Nov 9, 2021 at 12:43:20PM -0500, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > Daniel Gustafsson writes: > > I'm not Robert, but I still have an opinion here, and that it's that this > > feature would at best be an attractive nuisance. If you need compression > > on a

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-09 Thread Andrew Dunstan
On 11/9/21 09:12, Daniel Gustafsson wrote: > > 2901: SQL/JSON: functions > 2901: SQL/JSON: JSON_TABLE > == > Grouping these two together as they are in very similar states. The patches > seems to mostly move forward by rebases fixing smaller things. Andrew, do you > have

RE: Commitfest 2021-11 Patch Triage - Part 2

2021-11-09 Thread Floris Van Nee
> Daniel Gustafsson writes: > > 2773: libpq compression > > === > > This patch intended to provide libpq connection compression to > > "replace SSL compression" which was doomed when the patch was > written, > > and have since been removed altogether. The initial approach didn

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-09 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Daniel Gustafsson writes: > > 2773: libpq compression > > === > > This patch intended to provide libpq connection compression to "replace SSL > > compression" which was doomed when the patch was written, and have since > > b

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-09 Thread Pavel Stehule
Hi 2839: possibility to rename root namespace in plpgsql > = > This patch addresses a feature request for making plpgsql easier to work > with, > but the approach has been questioned with the thread stalling since March > in > one of these discus

Re: Commitfest 2021-11 Patch Triage - Part 2

2021-11-09 Thread Tom Lane
Daniel Gustafsson writes: > 2773: libpq compression > === > This patch intended to provide libpq connection compression to "replace SSL > compression" which was doomed when the patch was written, and have since been > removed altogether. The initial approach didn't get much tr