Re: Call perror on popen failure

2024-03-08 Thread Daniel Gustafsson
> On 8 Mar 2024, at 18:08, Peter Eisentraut wrote: > > On 08.03.24 11:05, Daniel Gustafsson wrote: >> If popen fails in pipe_read_line we invoke perror for the error message, and >> pipe_read_line is in turn called by find_other_exec which is used in both >> frontend and backend code. This is an

Re: Call perror on popen failure

2024-03-08 Thread Peter Eisentraut
On 08.03.24 11:05, Daniel Gustafsson wrote: If popen fails in pipe_read_line we invoke perror for the error message, and pipe_read_line is in turn called by find_other_exec which is used in both frontend and backend code. This is an old codepath, and it seems like it ought to be replaced with th

Re: Call perror on popen failure

2024-03-08 Thread Tom Lane
Daniel Gustafsson writes: > If popen fails in pipe_read_line we invoke perror for the error message, and > pipe_read_line is in turn called by find_other_exec which is used in both > frontend and backend code. This is an old codepath, and it seems like it > ought > to be replaced with the more c