On Fri, Nov 19, 2021 at 04:19:01PM +0900, Ken Kato wrote:
> I assume Michael has committed the modified version of the patch.
> Therefore, I changed the status to"committed" in Commitfest 2022-01.
> https://commitfest.postgresql.org/36/3418/
Thanks, I did not notice that :)
--
Michael
signature.
I have fixed (or discarded) that, and the parts for sequences, domains
and transforms remained. That looked like good enough on its own, so
applied those parts of the patch.
--
Michael
Thank you very much!
I assume Michael has committed the modified version of the patch.
Therefore, I changed th
On Thu, Nov 18, 2021 at 05:20:58PM +0900, Kyotaro Horiguchi wrote:
> So we could use COMPLETE_WITH_CS instead so that CREATE SEQUENCE
> behavess the same way with the existing behavior of TYPE.
Makes sense.
Another issue I have noticed with the patch is that it forgets to
apply quotes for the FRO
At Thu, 18 Nov 2021 17:17:25 +0900, Michael Paquier wrote
in
> On Thu, Nov 18, 2021 at 04:25:30PM +0900, Ken Kato wrote:
> > For this part, I did the following:
> > + else if (TailMatches("CREATE", "SEQUENCE", MatchAny, "AS") ||
> > +TailMatches("CREATE", "TEMP|TEMPORARY",
On Thu, Nov 18, 2021 at 04:25:30PM +0900, Ken Kato wrote:
> For this part, I did the following:
> + else if (TailMatches("CREATE", "SEQUENCE", MatchAny, "AS") ||
> + TailMatches("CREATE", "TEMP|TEMPORARY", "SEQUENCE",
> MatchAny, "AS"))
> + COMPLETE_WITH("small
+ else if (Matches("CREATE", "TRANSFORM", "FOR", MatchAny)
+ COMPLETE_WITH("LANGUAGE")
+ else if (Matches("CREATE", "TRANSFORM", "FOR", MatchAny,
"LANGUAGE")
Those three lines are wrong, for two different reasons and three
mistakes. You may want to compile your code b
On Wed, Nov 17, 2021 at 10:44:44AM +0900, Ken Kato wrote:
> I made a patch for this, so please have a look.
+ else if (Matches("CREATE", "TRANSFORM", "FOR", MatchAny)
+ COMPLETE_WITH("LANGUAGE")
+ else if (Matches("CREATE", "TRANSFORM", "FOR", MatchAny, "LANGUAGE")
Those
