Re: CREATE SUBSCRIPTION -- add missing tab-completes

2023-04-10 Thread Robert Haas
On Fri, Apr 7, 2023 at 9:29 AM Masahiko Sawada wrote: > I think that parameters used by the backend process when performing > CREATE SUBSCRIPTION belong to the first category. And other parameters > used by apply workers and tablesync workers belong to the second > category. Since slot_name is use

Re: CREATE SUBSCRIPTION -- add missing tab-completes

2023-04-09 Thread Amit Kapila
On Sun, Apr 9, 2023 at 11:33 AM Gregory Stark (as CFM) wrote: > > On Fri, 7 Apr 2023 at 01:28, Amit Kapila wrote: > > > > On Wed, Apr 5, 2023 at 5:58 AM Peter Smith wrote: > > > > > PSA patches to add those tab completions. > > > > LGTM, so pushed. > > I moved this to the next CF but actually I

Re: CREATE SUBSCRIPTION -- add missing tab-completes

2023-04-08 Thread Gregory Stark (as CFM)
On Fri, 7 Apr 2023 at 01:28, Amit Kapila wrote: > > On Wed, Apr 5, 2023 at 5:58 AM Peter Smith wrote: > > > PSA patches to add those tab completions. > > LGTM, so pushed. I moved this to the next CF but actually I just noticed the thread starts with the original patch being pushed. Maybe we shou

Re: CREATE SUBSCRIPTION -- add missing tab-completes

2023-04-07 Thread Amit Kapila
On Fri, Apr 7, 2023 at 6:59 PM Masahiko Sawada wrote: > > On Fri, Apr 7, 2023 at 6:10 PM Amit Kapila wrote: > > > > On Fri, Apr 7, 2023 at 1:12 PM Masahiko Sawada > > wrote: > > > > > > > Do you mean that because 'password_required' is used each time we make > > a connection to a publisher duri

Re: CREATE SUBSCRIPTION -- add missing tab-completes

2023-04-07 Thread Masahiko Sawada
On Fri, Apr 7, 2023 at 6:10 PM Amit Kapila wrote: > > On Fri, Apr 7, 2023 at 1:12 PM Masahiko Sawada wrote: > > > > On Fri, Apr 7, 2023 at 2:28 PM Amit Kapila wrote: > > > > > > On Wed, Apr 5, 2023 at 5:58 AM Peter Smith wrote: > > > > > > > > > > LGTM, so pushed. BTW, while looking at this, I

RE: CREATE SUBSCRIPTION -- add missing tab-completes

2023-04-07 Thread Zhijie Hou (Fujitsu)
On Friday, April 7, 2023 5:11 PM Amit Kapila wrote: > > On Fri, Apr 7, 2023 at 1:12 PM Masahiko Sawada > wrote: > > > > On Fri, Apr 7, 2023 at 2:28 PM Amit Kapila > wrote: > > > > > > On Wed, Apr 5, 2023 at 5:58 AM Peter Smith > wrote: > > > > > > > > > > LGTM, so pushed. BTW, while looking at

Re: CREATE SUBSCRIPTION -- add missing tab-completes

2023-04-07 Thread Amit Kapila
On Fri, Apr 7, 2023 at 1:12 PM Masahiko Sawada wrote: > > On Fri, Apr 7, 2023 at 2:28 PM Amit Kapila wrote: > > > > On Wed, Apr 5, 2023 at 5:58 AM Peter Smith wrote: > > > > > > > LGTM, so pushed. BTW, while looking at this, I noticed that newly > > added options "password_required" and "run_as_

Re: CREATE SUBSCRIPTION -- add missing tab-completes

2023-04-07 Thread Masahiko Sawada
On Fri, Apr 7, 2023 at 2:28 PM Amit Kapila wrote: > > On Wed, Apr 5, 2023 at 5:58 AM Peter Smith wrote: > > > > There are some recent comment that added new options for CREATE SUBSCRIPTION > > > ... > > PSA patches to add those tab completions. > > > > LGTM, so pushed. BTW, while looking at this,

Re: CREATE SUBSCRIPTION -- add missing tab-completes

2023-04-06 Thread Amit Kapila
On Wed, Apr 5, 2023 at 5:58 AM Peter Smith wrote: > > There are some recent comment that added new options for CREATE SUBSCRIPTION > ... > PSA patches to add those tab completions. > LGTM, so pushed. BTW, while looking at this, I noticed that newly added options "password_required" and "run_as_ow