Re: COPY FROM crash

2024-07-30 Thread David Rowley
On Tue, 30 Jul 2024 at 19:06, Zhang Mingli wrote: > I’ve updated the comments in patch v1 with an additional Assert. Thanks. I adjusted a little and used a StaticAssert instead then pushed. StaticAssert seems better as invalid values will result in compilation failure. David

Re: COPY FROM crash

2024-07-30 Thread Zhang Mingli
Hi, Zhang Mingli www.hashdata.xyz On Jul 30, 2024 at 13:37 +0800, Kirill Reshke , wrote: > > Just to be clear, you are facing this on HEAD, on on REL_14_STABLE? Postgres HEAD.

Re: COPY FROM crash

2024-07-30 Thread Zhang Mingli
Hi, Zhang Mingli www.hashdata.xyz On Jul 30, 2024 at 13:35 +0800, David Rowley , wrote: > > If you're only able > to get it to misbehave by setting MAX_PARTITION_BUFFERS to less than > 2, then my suggested fix would be to add a comment to say that values > less than to are not supported. Right.

Re: COPY FROM crash

2024-07-29 Thread Kirill Reshke
Hi! On Tue, 30 Jul 2024 at 08:52, Zhang Mingli wrote: > > Hi, all > > I got a crash when copy partition tables with mass data in Cloudberry > DB[0](based on Postgres14.4, Greenplum 7). > > I have a test on Postgres and it has the similar issue(different places but > same function). Just to be

Re: COPY FROM crash

2024-07-29 Thread David Rowley
On Tue, 30 Jul 2024 at 15:52, Zhang Mingli wrote: > I have a test on Postgres and it has the similar issue(different places but > same function). > > However it’s a little hard to reproduce because it happened when inserting > next tuple after a previous copy multi insert buffer is flushed. > >