Re: C testing for Postgres

2019-07-02 Thread Adam Berlin
> Just to clarify what Adam is proposing in this thread is *not* a fault > injection framework. > Yes, thanks for clarifying Ashwin. Sorry Michael, this testing framework is more like these other frameworks: Java with Junit + Hamcrest: http://hamcrest.org/JavaHamcrest/tutorial Ruby with Rspec: h

Re: C testing for Postgres

2019-07-02 Thread Ashwin Agrawal
On Mon, Jul 1, 2019 at 11:26 PM Michael Paquier wrote: > On Fri, Jun 28, 2019 at 09:42:54AM -0400, Adam Berlin wrote: > > If we were to use this tool, would the community want to vendor the > > framework in the Postgres repository, or keep it in a separate repository > > that produces a versioned

Re: C testing for Postgres

2019-07-01 Thread Michael Paquier
On Fri, Jun 28, 2019 at 09:42:54AM -0400, Adam Berlin wrote: > If we were to use this tool, would the community want to vendor the > framework in the Postgres repository, or keep it in a separate repository > that produces a versioned shared library? Well, my take is that having a base infrastruct

Re: C testing for Postgres

2019-06-28 Thread Jesse Zhang
On Fri, Jun 28, 2019 at 10:37 AM Adam Berlin wrote: > > If we were to use this tool, would the community want to vendor the > framework in the Postgres repository, or keep it in a separate > repository that produces a versioned shared library? > If the library is going to actively evolve, we shou

Re: C testing for Postgres

2019-06-28 Thread David Fetter
On Fri, Jun 28, 2019 at 09:42:54AM -0400, Adam Berlin wrote: > Here are my takeaways from the previous discussions: > > * there *is* interest in testing Yep. > * we shouldn't take it too far > * there are already tests being written under `src/test/modules`, but > without a consistent way of des

Re: C testing for Postgres

2019-06-28 Thread Adam Berlin
Here are my takeaways from the previous discussions: * there *is* interest in testing * we shouldn't take it too far * there are already tests being written under `src/test/modules`, but without a consistent way of describing expectations and displaying results * no tool was chosen If we were to

Re: C testing for Postgres

2019-06-28 Thread Dmitry Dolgov
> On Fri, Jun 28, 2019 at 11:38 AM Adam Berlin wrote: > > During the unconference at PGCon in Ottawa, I asked about writing C-based > tests for Postgres. There was interest in trying a tool and also some > hesitation to depend on a third-party library. So, I wrote a tool that I'd > like to contrib