Re: Building Postgres with lz4 on Visual Studio

2022-04-30 Thread Andres Freund
Hi, On 2022-04-29 08:50:56 -0400, Andrew Dunstan wrote: > I agree that we should use perl's -e to test that the files actually > exists. But I don't think we should try to adjust to everything the zstd > and lz4 people put in their release files. They are just horribly > inconsistent. Right now i

Re: Building Postgres with lz4 on Visual Studio

2022-04-30 Thread Andrew Dunstan
On 2022-04-29 Fr 08:50, Andrew Dunstan wrote: > What I did was to install the packages using vcpkg[1] which is a > standard framework created by Microsoft for installing package > libraries. It does install the .lib files in a sane place > (installdir/lib), but it doesn't use the lib suffix. Also

Re: Building Postgres with lz4 on Visual Studio

2022-04-29 Thread Andrew Dunstan
On 2022-04-29 Fr 08:50, Andrew Dunstan wrote: > On 2022-04-26 Tu 16:26, Robert Haas wrote: >> On Wed, Apr 13, 2022 at 10:22 AM Melih Mutlu wrote: >>> What I realized is that c:\lz4\lib\liblz4.lib actually does not exist. >>> The latest versions of lz4, downloaded from [2], do not contain \liblz4.

Re: Building Postgres with lz4 on Visual Studio

2022-04-29 Thread Andrew Dunstan
On 2022-04-26 Tu 16:26, Robert Haas wrote: > On Wed, Apr 13, 2022 at 10:22 AM Melih Mutlu wrote: >> What I realized is that c:\lz4\lib\liblz4.lib actually does not exist. >> The latest versions of lz4, downloaded from [2], do not contain \liblz4.lib >> anymore, as opposed to what's written here

Re: Building Postgres with lz4 on Visual Studio

2022-04-26 Thread Robert Haas
On Wed, Apr 13, 2022 at 10:22 AM Melih Mutlu wrote: > What I realized is that c:\lz4\lib\liblz4.lib actually does not exist. > The latest versions of lz4, downloaded from [2], do not contain \liblz4.lib > anymore, as opposed to what's written here [3]. Also there isn't a lib folder > too. > > Af

Re: Building Postgres with lz4 on Visual Studio

2022-04-25 Thread Michael Paquier
On Wed, Apr 13, 2022 at 05:21:41PM +0300, Melih Mutlu wrote: > I tried to build Postgres from source using Visual Studio 19. It worked all > good. > Then I wanted to build it with some dependencies, started with the ones > listed here [1]. But I'm having some issues with lz4. > > First I downloade

Re: Building Postgres with lz4 on Visual Studio

2022-04-22 Thread Andres Freund
Hi, Michael, Dilip, I think you worked most in this area? Based on 9ca40dcd4d0cad43d95a9a253fafaa9a9ba7de24 Robert, added you too, because zstd seems to have the same issue (based on the tail of the quoted email below). On 2022-04-13 17:21:41 +0300, Melih Mutlu wrote: > I tried to build Postgres