Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun

2018-09-09 Thread Alexander Korotkov
On Thu, Sep 6, 2018 at 9:02 PM R, Siva wrote: > I'm also running into this assert with the workload, I think my patch is > not handling the case where the action is add items on the last segment > of the page correctly. I'm still investigating the issue further to find > the > source of the bug.

Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun

2018-09-06 Thread Alexander Korotkov
On Thu, Sep 6, 2018 at 12:53 AM R, Siva wrote: > On Tue, Sep 5, 2018 at 08:55 PM, Alexander Korotkov > wrote: > > Finally I managed to reproduce the bug. The scenario is following. > > Underlying idea is that when insertion of multiple tuples goes to the > > beginning of the page and this inser

Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun

2018-09-05 Thread Alexander Korotkov
On Wed, Sep 5, 2018 at 5:05 PM Alexander Korotkov wrote: > On Wed, Sep 5, 2018 at 2:39 PM Alexander Korotkov > wrote: > > On Wed, Sep 5, 2018 at 12:26 PM Alexander Korotkov > > wrote: > > > On Wed, Sep 5, 2018 at 1:45 AM R, Siva wrote: > > > > On Tue, Sep 4, 2018 at 09:16 PM, Alexander Korotkov

Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun

2018-09-05 Thread Masahiko Sawada
On Wed, Sep 5, 2018 at 4:59 AM, R, Siva wrote: > Hi, > > We recently encountered an issue where the opaque data flags on a gin data > leaf page was corrupted while replaying a gin insert WAL record. Upon > further examination of the redo code, we found a bug in ginRedoRecompress > code, which extr

Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun

2018-09-05 Thread Alexander Korotkov
On Wed, Sep 5, 2018 at 2:39 PM Alexander Korotkov wrote: > On Wed, Sep 5, 2018 at 12:26 PM Alexander Korotkov > wrote: > > On Wed, Sep 5, 2018 at 1:45 AM R, Siva wrote: > > > On Tue, Sep 4, 2018 at 09:16 PM, Alexander Korotkov > > > wrote: > > > > Do you have a test scenario for reproduction o

Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun

2018-09-05 Thread Alexander Korotkov
On Wed, Sep 5, 2018 at 12:26 PM Alexander Korotkov wrote: > On Wed, Sep 5, 2018 at 1:45 AM R, Siva wrote: > > On Tue, Sep 4, 2018 at 09:16 PM, Alexander Korotkov > > wrote: > > > Do you have a test scenario for reproduction of this issue? We need > > > it to ensure that fix is correct. > > > >

Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun

2018-09-05 Thread Alexander Korotkov
On Wed, Sep 5, 2018 at 1:45 AM R, Siva wrote: > On Tue, Sep 4, 2018 at 09:16 PM, Alexander Korotkov > wrote: > > Do you have a test scenario for reproduction of this issue? We need > > it to ensure that fix is correct. > > Unfortunately, I do not have a way of reproducing this issue. > So far I

Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun

2018-09-04 Thread Peter Geoghegan
On Tue, Sep 4, 2018 at 12:59 PM, R, Siva wrote: > We recently encountered an issue where the opaque data flags on a gin data > leaf page was corrupted while replaying a gin insert WAL record. Upon > further examination of the redo code, we found a bug in ginRedoRecompress > code, which extracts th

Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun

2018-09-04 Thread Alexander Korotkov
Hi, Siva! On Tue, Sep 4, 2018 at 11:01 PM R, Siva wrote: > We recently encountered an issue where the opaque data flags on a gin data > leaf page was corrupted while replaying a gin insert WAL record. Upon further > examination of the redo code, we found a bug in ginRedoRecompress code, which