Re: Better context for "TAP tests not enabled" error message

2021-10-04 Thread Daniel Gustafsson
> On 3 Oct 2021, at 01:27, Daniel Gustafsson wrote: > >> On 3 Oct 2021, at 00:39, Kevin Burke wrote: > >> Updated patch that removes the "Maybe" > > Thanks, I’ll take care of this tomorrow along with Rachels patch. I was off-by-one on date, but it's been pushed to master now. Thanks! -- Dan

Re: Better context for "TAP tests not enabled" error message

2021-10-03 Thread Kevin Burke
Updated patch that removes the "Maybe" -- Kevin Burke phone: 925-271-7005 | kevin.burke.dev On Sat, Oct 2, 2021 at 11:19 AM Tom Lane wrote: > Daniel Gustafsson writes: > >> On 2 Oct 2021, at 02:09, Kevin Burke wrote: > >> This patch amends the error message to give help to the user. > > > I

Re: Better context for "TAP tests not enabled" error message

2021-10-02 Thread Daniel Gustafsson
> On 3 Oct 2021, at 00:39, Kevin Burke wrote: > Updated patch that removes the "Maybe" Thanks, I’ll take care of this tomorrow along with Rachels patch. ./daniel

Re: Better context for "TAP tests not enabled" error message

2021-10-02 Thread Tom Lane
Daniel Gustafsson writes: >> On 2 Oct 2021, at 02:09, Kevin Burke wrote: >> This patch amends the error message to give help to the user. > I think this makes sense, +1. I'd take out the "Maybe"; the diagnosis seems pretty certain. regards, tom lane

Re: Better context for "TAP tests not enabled" error message

2021-10-02 Thread Daniel Gustafsson
> On 2 Oct 2021, at 02:09, Kevin Burke wrote: > This patch amends the error message to give help to the user. I think this makes sense, and is in line with Rachels patch [0] a few days ago that I plan on pushing; small error hints which wont get in the way of established developers, but which ca