Re: Batching in executor

2025-10-30 Thread Daniil Davydov
Hi, On Wed, Oct 29, 2025 at 9:23 AM Amit Langote wrote: > > Hi Daniil, > > On Tue, Oct 28, 2025 at 11:32 PM Daniil Davydov <[email protected]> wrote: > > > > Hi, > > > > As far as I understand, this work partially overlaps with what we did in the > > thread [1] (in short - we introduce support

Re: Batching in executor

2025-10-28 Thread Amit Langote
On Tue, Oct 28, 2025 at 10:40 PM Amit Langote wrote: > That would be nice to see if you have the time, but maybe after I post > a new version. I’ve created a CF entry marked WoA for this in the next CF under the title “Batching in executor, part 1: add batch variant of table AM scan API.” The ide

Re: Batching in executor

2025-10-28 Thread Amit Langote
Hi Daniil, On Tue, Oct 28, 2025 at 11:32 PM Daniil Davydov <[email protected]> wrote: > > Hi, > > As far as I understand, this work partially overlaps with what we did in the > thread [1] (in short - we introduce support for batching within the > ModifyTable > node). Am I correct? There might

Re: Batching in executor

2025-10-28 Thread Daniil Davydov
Hi, As far as I understand, this work partially overlaps with what we did in the thread [1] (in short - we introduce support for batching within the ModifyTable node). Am I correct? It's worth saying that the patch in that thread is already quite old - now I have an improved implementation and te

Re: Batching in executor

2025-10-28 Thread Amit Langote
On Tue, Oct 28, 2025 at 1:18 AM Tomas Vondra wrote: > On 10/27/25 08:24, Amit Langote wrote: > > Thank you for reviewing the patch and taking the time to run those > > experiments. I appreciate the detailed feedback and questions. I also > > apologize for my late reply, I spent perhaps way too mu

Re: Batching in executor

2025-10-28 Thread Amit Langote
Hi Peter, Thanks for chiming in here. On Tue, Oct 28, 2025 at 2:37 AM Peter Geoghegan wrote: > > On Mon, Sep 29, 2025 at 7:01 AM Tomas Vondra wrote: > > While looking at the patch, I couldn't help but think about the index > > prefetching stuff that I work on. It also introduces the concept of

Re: Batching in executor

2025-10-27 Thread Peter Geoghegan
On Mon, Sep 29, 2025 at 7:01 AM Tomas Vondra wrote: > While looking at the patch, I couldn't help but think about the index > prefetching stuff that I work on. It also introduces the concept of a > "batch", for passing data between an index AM and the executor. It's > interesting how different the

Re: Batching in executor

2025-10-27 Thread Tomas Vondra
On 10/27/25 08:24, Amit Langote wrote: > Hi Tomas, > > On Mon, Sep 29, 2025 at 8:01 PM Tomas Vondra wrote: >> >> Hi Amit, >> >> Thanks for the patch. I took a look over the weekend, and done a couple >> experiments / benchmarks, so let me share some initial feedback (or >> rather a bunch of quest

Re: Batching in executor

2025-10-27 Thread Amit Langote
Hi Tomas, On Mon, Sep 29, 2025 at 8:01 PM Tomas Vondra wrote: > > Hi Amit, > > Thanks for the patch. I took a look over the weekend, and done a couple > experiments / benchmarks, so let me share some initial feedback (or > rather a bunch of questions I came up with). Thank you for reviewing the

Re: Batching in executor

2025-10-17 Thread Amit Langote
Hi Bruce, On Fri, Sep 26, 2025 at 10:49 PM Bruce Momjian wrote: > On Fri, Sep 26, 2025 at 10:28:33PM +0900, Amit Langote wrote: > > At PGConf.dev this year we had an unconference session [1] on whether > > the community can support an additional batch executor. The discussion > > there led me to

Re: Batching in executor

2025-09-30 Thread Amit Langote
On Tue, Sep 30, 2025 at 11:11 AM Amit Langote wrote: > Hi Tomas, > > Thanks a lot for your comments and benchmarking. > > I plan to reply to your detailed comments and benchmark results For now, I reran a few benchmarks with the master branch as an explicit baseline, since Tomas reported possible

Re: Batching in executor

2025-09-26 Thread Bruce Momjian
On Fri, Sep 26, 2025 at 10:28:33PM +0900, Amit Langote wrote: > At PGConf.dev this year we had an unconference session [1] on whether > the community can support an additional batch executor. The discussion > there led me to start hacking on $subject. I have also had off-list > discussions on this