On Thu, Jun 1, 2023 at 6:47 AM Greg Stark wrote:
> What error would one expect to see? I did have a case where vacuum was
> erroring on a btree in $previous_job.
You mean in general? It's usually this one:
https://gitlab.com/gitlab-org/gitlab/-/issues/381443
In the case of this particular issu
On Mon, May 22, 2023, 12:31 Peter Geoghegan wrote:
> On Sun, May 21, 2023 at 11:51 PM Heikki Linnakangas
> wrote:
> > Any idea what might cause this corruption?
>
> Not really, no. As far as I know the specific case that was brought to
> my attention (that put me on the path to writing this patc
On Mon, May 22, 2023 at 10:59 AM Peter Geoghegan wrote:
> Attached is v2, which does it that way. It also adjusts the approach
> taken to release locks and pins when the left sibling validation check
> fails.
I pushed this just now, backpatching all the way.
> Not including a revised amcheck pat
On Mon, May 22, 2023 at 9:22 AM Peter Geoghegan wrote:
> > This comment notes that this is similar to what we did with the left
> > sibling, but there isn't really any mention at the left sibling code
> > about avoiding hard ERRORs. Feels a bit backwards. Maybe move the
> > comment about avoiding
On Sun, May 21, 2023 at 11:51 PM Heikki Linnakangas wrote:
> Any idea what might cause this corruption?
Not really, no. As far as I know the specific case that was brought to
my attention (that put me on the path to writing this patch) was just
an isolated incident. The interesting detail (if any
On 20/05/2023 05:17, Peter Geoghegan wrote:
It has come to my attention that there is a remaining issue of the
same general nature in nbtree VACUUM's page deletion code. Though this
remaining issue seems significantly less likely to come up in
practice, there is no reason to take any chances here
