Re: Avoid possible dereference null pointer (contrib/postgres_fdw/postgres_fdw.c)

On Fri, Jul 4, 2025 at 2:41 PM Etsuro Fujita wrote: > On Wed, Jun 18, 2025 at 8:33 PM Ranier Vilela wrote: > > Em qua., 18 de jun. de 2025 às 07:29, Etsuro Fujita > > escreveu: > >> Considering fpextra cannot be NULL, I think the proposed change is > >> something more than necessary. IMO I thi

Re: Avoid possible dereference null pointer (contrib/postgres_fdw/postgres_fdw.c)

On Wed, Jun 18, 2025 at 8:33 PM Ranier Vilela wrote: > Em qua., 18 de jun. de 2025 às 07:29, Etsuro Fujita > escreveu: >> On Tue, Jun 17, 2025 at 11:03 PM Fujii Masao >> wrote: >> > On 2025/06/17 20:37, Ranier Vilela wrote: >> > > Em ter., 17 de jun. de 2025 às 06:09, Etsuro Fujita >> > > mail

Re: Avoid possible dereference null pointer (contrib/postgres_fdw/postgres_fdw.c)

Em qua., 18 de jun. de 2025 às 07:29, Etsuro Fujita escreveu: > On Tue, Jun 17, 2025 at 11:03 PM Fujii Masao > wrote: > > On 2025/06/17 20:37, Ranier Vilela wrote: > > > Em ter., 17 de jun. de 2025 às 06:09, Etsuro Fujita < > etsuro.fuj...@gmail.com > escreveu: >

Re: Avoid possible dereference null pointer (contrib/postgres_fdw/postgres_fdw.c)

On Tue, Jun 17, 2025 at 11:03 PM Fujii Masao wrote: > On 2025/06/17 20:37, Ranier Vilela wrote: > > Em ter., 17 de jun. de 2025 às 06:09, Etsuro Fujita > > mailto:etsuro.fuj...@gmail.com>> escreveu: > > On Tue, Jun 17, 2025 at 2:38 PM Fujii Masao > > mailto:masao.fu...@oss.nttdata.com>> wrot

Re: Avoid possible dereference null pointer (contrib/postgres_fdw/postgres_fdw.c)

On 2025/06/17 20:37, Ranier Vilela wrote: Em ter., 17 de jun. de 2025 às 06:09, Etsuro Fujita mailto:etsuro.fuj...@gmail.com>> escreveu: Hi, On Tue, Jun 17, 2025 at 2:38 PM Fujii Masao mailto:masao.fu...@oss.nttdata.com>> wrote: >                                 adjust_foreign_g

Re: Avoid possible dereference null pointer (contrib/postgres_fdw/postgres_fdw.c)

Em ter., 17 de jun. de 2025 às 06:09, Etsuro Fujita escreveu: > Hi, > > On Tue, Jun 17, 2025 at 2:38 PM Fujii Masao > wrote: > > adjust_foreign_grouping_path_cost(root, > pathkeys, > > > retrieved_rows, width, > > - >

Re: Avoid possible dereference null pointer (contrib/postgres_fdw/postgres_fdw.c)

Hi, On Tue, Jun 17, 2025 at 2:38 PM Fujii Masao wrote: > adjust_foreign_grouping_path_cost(root, > pathkeys, > > retrieved_rows, width, > -

Re: Avoid possible dereference null pointer (contrib/postgres_fdw/postgres_fdw.c)

On 2025/06/17 4:48, Ranier Vilela wrote: Hi. In the function *estimate_path_cost_size* the parameter fpextra can be NULL. Yes. It is necessary to always check its validity, as is already done in other parts of the source. patch attached. adjust_foreign_