On Wed, Jan 03, 2024 at 12:56:58AM -0500, Tom Lane wrote:
> Yeah. A quick grep shows that we have 16 uses of "vertices" and
> only this one of "vertexes". It's not really wrong, but +1 for
> making it match the others.
Applied this one as 793ecff7df80 on HEAD.
> I'd leave this alone, it's not w
Robert Haas writes:
> On Mon, Jan 1, 2024 at 6:05 PM Dagfinn Ilmari Mannsåker
> wrote:
>> Thanks. I've fixed the commit message (and elaborated it a bit more why
>> I think it's a valid and safe fix).
>
> Regarding 0001:
>
> - AIUI, check_decls.m4 is copied from an upstream project, so I don't
>
Michael Paquier writes:
> 0010 is indeed the "correct" plural form for vertex I've known but
> "vertexes" is not wrong either. Perhaps that's worth changing on
> consistency grounds?
Yeah. A quick grep shows that we have 16 uses of "vertices" and
only this one of "vertexes". It's not really wr
On Tue, Jan 02, 2024 at 12:34:20PM -0500, Robert Haas wrote:
> 0002-0005 look OK to me, so I committed those as well.
Cool, thanks.
> With regard to 0006, we typically use indexes rather than indices as
> the plural of "index", although exceptions exist.
>
> I haven't looked at the rest.
I got
On Mon, Jan 1, 2024 at 6:05 PM Dagfinn Ilmari Mannsåker
wrote:
> Thanks. I've fixed the commit message (and elaborated it a bit more why
> I think it's a valid and safe fix).
Regarding 0001:
- AIUI, check_decls.m4 is copied from an upstream project, so I don't
think we should tinker with it.
- I
Shubham Khanna writes:
> I was reviewing the Patch and came across a minor issue that the Patch
> does not apply on the current Head. Please provide the updated version
> of the patch.
Thanks for the heads-up. Commit 5ccb3bb13dcbedc30d015fc06d306d5106701e16
removed one of the instances of "data
On Thu, Dec 28, 2023 at 3:21 AM Dagfinn Ilmari Mannsåker
wrote:
>
> Hi folks,
>
> I was playing around with the `typos` tool
> (https://github.com/crate-ci/typos), and thought I'd run it on the
> posgres repo for fun. After a bit of tweaking to get rid of most false
> positives (see separately at
