Re: Assertion failure on PG15 with modified test_shm_mq test

2022-08-23 Thread Kyotaro Horiguchi
At Thu, 18 Aug 2022 16:58:24 +0530, Pavan Deolasee wrote in > Hi, > > On Thu, Aug 18, 2022 at 5:38 AM Andres Freund wrote: > > > We can't move pgstat shutdown into on_dsm callback because that's too late > > to > > allocate *new* dsm segments, which we might need to do while flushing > > out

Re: Assertion failure on PG15 with modified test_shm_mq test

2022-08-18 Thread Pavan Deolasee
Hi, On Thu, Aug 18, 2022 at 5:38 AM Andres Freund wrote: > I don't think we have the infrastructure for a nice solution to this at the > moment - we need a fairly large overhaul of process initialization / > shutdown > to handle these interdependencies nicely. > > Ok, understood. > We can't mo

Re: Assertion failure on PG15 with modified test_shm_mq test

2022-08-17 Thread Andres Freund
Hi, On 2022-08-17 15:02:28 +0900, Michael Paquier wrote: > On Wed, Aug 17, 2022 at 11:15:28AM +0530, Pavan Deolasee wrote: > > I notice that pgstat_shutdown_hook() is registered as a before-shmem-exit > > callback. The callback is responsible for detaching from the pgstat shared > > memory segment

Re: Assertion failure on PG15 with modified test_shm_mq test

2022-08-17 Thread Andres Freund
Hi, On 2022-08-17 11:15:28 +0530, Pavan Deolasee wrote: > I've a slightly modified version of test_shm_mq, that I changed to include > a shared fileset. The motivation to do that came because I hit an > assertion failure with PG15 while doing some development work on BDR and I > suspected it to b

Re: Assertion failure on PG15 with modified test_shm_mq test

2022-08-16 Thread Michael Paquier
On Wed, Aug 17, 2022 at 11:15:28AM +0530, Pavan Deolasee wrote: > I notice that pgstat_shutdown_hook() is registered as a before-shmem-exit > callback. The callback is responsible for detaching from the pgstat shared > memory segment. But looks like other parts of the system still expect it to > be