Re: Assert failure in base_yyparse

2025-04-14 Thread Richard Guo
On Fri, Mar 28, 2025 at 7:12 PM Евгений Горбанев wrote: > If you replace is_not_null with NOT NULL in the query, everything works > correctly. > It seems that is_not_null is an incorrect keyword and it should not be > used, but I don't understand how it gets here. It seems what happens is that in

Re: Assert failure in base_yyparse

2025-03-28 Thread Евгений Горбанев
Also, I think IsA is a better choice for checking the node type. Agree, IsA is better. Fixed in the patch. On Fri, Mar 28, 2025 at 6:05 PM Richard Guo wrote: Hmm, I wonder if we should allow the use of the 'is_not_null' keyword in xmltable. According to the doc, it seems that users should d

Re: Assert failure in base_yyparse

2025-03-28 Thread Richard Guo
On Fri, Mar 28, 2025 at 6:05 PM Richard Guo wrote: > Nice catch. Yeah, is_not_null is a valid column option in xmltable. > In you example, the value of the is_not_null option is "|| 'c'", which > is interpreted as an A_Expr. > > I wonder if the value's type should be checked earlier, rather than

Re: Assert failure in base_yyparse

2025-03-28 Thread Richard Guo
On Fri, Mar 28, 2025 at 4:40 PM Евгений Горбанев wrote: > Got an assert failure when fuzzing the raw_parser function. > The query to reproduce: > SELECT xmltable.* FROM xmltest2, LATERAL xmltable('/d/r' PASSING x > COLUMNS a int PATH '' || lower(_path) is_not_null|| 'c'); > > If I understand corre