Re: Apple's ranlib warns about protocol_openssl.c

2022-09-26 Thread Andres Freund
Hi, On 2021-12-16 21:13:20 +0100, Daniel Gustafsson wrote: > > On 16 Dec 2021, at 19:22, Tom Lane wrote: > > > Having said that, I'm not seeing any such warning when I build > > with openssl 1.1.1k on my own Mac, so I'm a bit confused why > > Thomas sees it. > > Maybe it's dependant on macOS/XCod

Re: Apple's ranlib warns about protocol_openssl.c

2021-12-30 Thread Tom Lane
Andres Freund writes: > I also see it on an m1 mini I got when building against openssl 3. Huh, I wonder why I'm not seeing it. > There is -no_warning_for_no_symbols in apple's ranlib. But perhaps > there's another way around this: > We have ssl_protocol_version_to_openssl() in both be-secure-op

Re: Apple's ranlib warns about protocol_openssl.c

2021-12-30 Thread Andres Freund
Hi, On 2021-12-17 14:26:53 +1300, Thomas Munro wrote: > On Fri, Dec 17, 2021 at 9:38 AM Tom Lane wrote: > > Could be. I tried it on Monterey, but not anything older. > > (longfin is still on Big Sur, because I've been lazy about > > updating it.) > > Hmm. Happened[1] with Andres's CI scripts,

Re: Apple's ranlib warns about protocol_openssl.c

2021-12-16 Thread Thomas Munro
On Fri, Dec 17, 2021 at 9:38 AM Tom Lane wrote: > Daniel Gustafsson writes: > >> On 16 Dec 2021, at 19:22, Tom Lane wrote: > >> Having said that, I'm not seeing any such warning when I build > >> with openssl 1.1.1k on my own Mac, so I'm a bit confused why > >> Thomas sees it. > > > Maybe it's d

Re: Apple's ranlib warns about protocol_openssl.c

2021-12-16 Thread Tom Lane
Daniel Gustafsson writes: >> On 16 Dec 2021, at 19:22, Tom Lane wrote: >> Having said that, I'm not seeing any such warning when I build >> with openssl 1.1.1k on my own Mac, so I'm a bit confused why >> Thomas sees it. > Maybe it's dependant on macOS/XCode release? I see the warning on my Cata

Re: Apple's ranlib warns about protocol_openssl.c

2021-12-16 Thread Daniel Gustafsson
> On 16 Dec 2021, at 19:22, Tom Lane wrote: > Having said that, I'm not seeing any such warning when I build > with openssl 1.1.1k on my own Mac, so I'm a bit confused why > Thomas sees it. Maybe it's dependant on macOS/XCode release? I see the warning on my Catalina laptop. -- Daniel Gustafss

Re: Apple's ranlib warns about protocol_openssl.c

2021-12-16 Thread Tom Lane
Thomas Munro writes: > On Fri, Dec 17, 2021 at 4:48 AM Peter Eisentraut > wrote: >> These are not errors, right? So why is this a problem? > Yeah they're just warnings. I don't personally care if we just ignore > them until we drop OpenSSL < 1.1.0 or macOS < 10.something. I > mentioned it bec

Re: Apple's ranlib warns about protocol_openssl.c

2021-12-16 Thread Thomas Munro
On Fri, Dec 17, 2021 at 4:48 AM Peter Eisentraut wrote: > These are not errors, right? So why is this a problem? Yeah they're just warnings. I don't personally care if we just ignore them until we drop OpenSSL < 1.1.0 or macOS < 10.something. I mentioned it because in the past we worked to get

Re: Apple's ranlib warns about protocol_openssl.c

2021-12-16 Thread Peter Eisentraut
On 16.12.21 16:25, Tom Lane wrote: Thomas Munro writes: Apple's ranlib doesn't like empty translation units[1], but protocol_openssl.c doesn't define any symbols (unless you have an ancient EOL'd openssl), so longfin and CI say: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefa

Re: Apple's ranlib warns about protocol_openssl.c

2021-12-16 Thread Tom Lane
Thomas Munro writes: > Apple's ranlib doesn't like empty translation units[1], but > protocol_openssl.c doesn't define any symbols (unless you have an > ancient EOL'd openssl), so longfin and CI say: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: