Re: Allow CURRENT_ROLE in GRANTED BY

2021-11-26 Thread Daniel Gustafsson
> On 18 Nov 2021, at 14:42, Daniel Gustafsson wrote: > >> On 18 Nov 2021, at 14:41, Peter Eisentraut >> wrote: >> >> On 16.11.21 15:27, Daniel Gustafsson wrote: > On 16 Nov 2021, at 15:04, Daniel Gustafsson wrote: ..or should the attached small diff be applied to fix it? >>> Actuall

Re: Allow CURRENT_ROLE in GRANTED BY

2021-11-18 Thread Daniel Gustafsson
> On 18 Nov 2021, at 14:41, Peter Eisentraut > wrote: > > On 16.11.21 15:27, Daniel Gustafsson wrote: On 16 Nov 2021, at 15:04, Daniel Gustafsson wrote: >>> ..or should the attached small diff be applied to fix it? >> Actually it shouldn't, I realized when hitting Send that it was the

Re: Allow CURRENT_ROLE in GRANTED BY

2021-11-18 Thread Peter Eisentraut
On 16.11.21 15:27, Daniel Gustafsson wrote: On 16 Nov 2021, at 15:04, Daniel Gustafsson wrote: ..or should the attached small diff be applied to fix it? Actually it shouldn't, I realized when hitting Send that it was the wrong version. The attached is the proposed diff. This appears to h

Re: Allow CURRENT_ROLE in GRANTED BY

2021-11-16 Thread Daniel Gustafsson
> On 16 Nov 2021, at 15:04, Daniel Gustafsson wrote: > ..or should the attached small diff be applied to fix it? Actually it shouldn't, I realized when hitting Send that it was the wrong version. The attached is the proposed diff. -- Daniel Gustafsson https://vmware.com/ grant

Re: Allow CURRENT_ROLE in GRANTED BY

2021-11-16 Thread Daniel Gustafsson
> On 30 Jan 2021, at 09:51, Peter Eisentraut > wrote: > > On 2020-12-30 13:43, Simon Riggs wrote: >> On Thu, 10 Dec 2020 at 18:40, Peter Eisentraut >> wrote: >>> >>> On 2020-06-24 20:21, Peter Eisentraut wrote: On 2020-06-24 10:12, Vik Fearing wrote: > On 6/24/20 8:35 AM, Peter Eisent

Re: Allow CURRENT_ROLE in GRANTED BY

2021-01-30 Thread Peter Eisentraut
On 2020-12-30 13:43, Simon Riggs wrote: On Thu, 10 Dec 2020 at 18:40, Peter Eisentraut wrote: On 2020-06-24 20:21, Peter Eisentraut wrote: On 2020-06-24 10:12, Vik Fearing wrote: On 6/24/20 8:35 AM, Peter Eisentraut wrote: I was checking some loose ends in SQL conformance, when I noticed: W

Re: Allow CURRENT_ROLE in GRANTED BY

2020-12-30 Thread Simon Riggs
On Thu, 10 Dec 2020 at 18:40, Peter Eisentraut wrote: > > On 2020-06-24 20:21, Peter Eisentraut wrote: > > On 2020-06-24 10:12, Vik Fearing wrote: > >> On 6/24/20 8:35 AM, Peter Eisentraut wrote: > >>> I was checking some loose ends in SQL conformance, when I noticed: We > >>> support GRANT role .

Re: Allow CURRENT_ROLE in GRANTED BY

2020-12-10 Thread Peter Eisentraut
On 2020-06-24 20:21, Peter Eisentraut wrote: On 2020-06-24 10:12, Vik Fearing wrote: On 6/24/20 8:35 AM, Peter Eisentraut wrote: I was checking some loose ends in SQL conformance, when I noticed: We support GRANT role ... GRANTED BY CURRENT_USER, but we don't support CURRENT_ROLE in that place,

Re: Allow CURRENT_ROLE in GRANTED BY

2020-09-17 Thread Tom Lane
Peter Eisentraut writes: > committed A couple of buildfarm animals are reporting instability in the modified rolenames test, eg https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hoverfly&dt=2020-09-17%2010%3A27%3A36 https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2020-09-1

Re: Allow CURRENT_ROLE in GRANTED BY

2020-09-17 Thread Peter Eisentraut
On 2020-09-11 22:05, Alvaro Herrera wrote: On 2020-Aug-26, Peter Eisentraut wrote: Here is another patch that also makes comprehensive updates to the rolenames tests under src/test/modules/unsafe_tests/. Looks good to me. You need to DROP ROLE "current_role" at the bottom of rolenames.sql, t

Re: Allow CURRENT_ROLE in GRANTED BY

2020-09-11 Thread Alvaro Herrera
On 2020-Aug-26, Peter Eisentraut wrote: > Here is another patch that also makes comprehensive updates to the rolenames > tests under src/test/modules/unsafe_tests/. Looks good to me. You need to DROP ROLE "current_role" at the bottom of rolenames.sql, though (as well as DROP OWNED BY, I suppose.

Re: Allow CURRENT_ROLE in GRANTED BY

2020-09-10 Thread Peter Eisentraut
On 2020-09-07 12:02, Asif Rehman wrote: The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed The patch applies c

Re: Allow CURRENT_ROLE in GRANTED BY

2020-09-07 Thread Asif Rehman
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed The patch applies cleanly and looks fine to me. However would

Re: Allow CURRENT_ROLE in GRANTED BY

2020-06-29 Thread Peter Eisentraut
On 2020-06-24 23:08, Alvaro Herrera wrote: On 2020-Jun-24, Peter Eisentraut wrote: I was checking some loose ends in SQL conformance, when I noticed: We support GRANT role ... GRANTED BY CURRENT_USER, but we don't support CURRENT_ROLE in that place, even though in PostgreSQL they are equivalent

Re: Allow CURRENT_ROLE in GRANTED BY

2020-06-24 Thread Alvaro Herrera
On 2020-Jun-24, Peter Eisentraut wrote: > I was checking some loose ends in SQL conformance, when I noticed: We > support GRANT role ... GRANTED BY CURRENT_USER, but we don't support > CURRENT_ROLE in that place, even though in PostgreSQL they are equivalent. > Here is a trivial patch to add that.

Re: Allow CURRENT_ROLE in GRANTED BY

2020-06-24 Thread Peter Eisentraut
On 2020-06-24 10:12, Vik Fearing wrote: On 6/24/20 8:35 AM, Peter Eisentraut wrote: I was checking some loose ends in SQL conformance, when I noticed: We support GRANT role ... GRANTED BY CURRENT_USER, but we don't support CURRENT_ROLE in that place, even though in PostgreSQL they are equivalent

Re: Allow CURRENT_ROLE in GRANTED BY

2020-06-24 Thread Vik Fearing
On 6/24/20 8:35 AM, Peter Eisentraut wrote: > I was checking some loose ends in SQL conformance, when I noticed: We > support GRANT role ... GRANTED BY CURRENT_USER, but we don't support > CURRENT_ROLE in that place, even though in PostgreSQL they are > equivalent.  Here is a trivial patch to add t