On Thu, May 19, 2022 at 07:28:53AM -0400, Andrew Dunstan wrote:
> Looks ok. PostgreSQL::Version is designed so that the object behaves
> sanely in comparisons and when interpolated into a string.
Okay, I have applied this thing. I'll move back to my business with
the tests of pg_upgrade...
--
Mic
On Thu, May 19, 2022 at 07:28:53AM -0400, Andrew Dunstan wrote:
> Looks ok. PostgreSQL::Version is designed so that the object behaves
> sanely in comparisons and when interpolated into a string.
I saw that, and that's kind of nice when it comes to write
version-specific code paths in the tests ;)
On 2022-05-18 We 21:38, Michael Paquier wrote:
> Hi all,
> (Added Andrew in CC.)
>
> While working more on expanding the tests of pg_upgrade for
> cross-version checks, I have noticed that we don't expose a routine
> able to get back _pg_version from a node, which should remain a
> private field
> On 19 May 2022, at 03:38, Michael Paquier wrote:
> Any objections or comments about the addition of a routine to get the
> PostgreSQL::Version, as of the attached?
I haven't tested the patch, but +1 on the idea.
--
Daniel Gustafsson https://vmware.com/
