Re: Adding further hardening to nbtree page deletion

2023-06-21 Thread Peter Geoghegan
On Tue, Jun 20, 2023 at 11:13 PM Peter Geoghegan wrote: > FWIW, I'm almost certain that I'll completely run out of ERRORs to > demote to LOGs before too long. In fact, this might very well be the > last ERROR that I ever have to demote to a LOG to harden nbtree > VACUUM. Pushed this just now, bac

Re: Adding further hardening to nbtree page deletion

2023-06-20 Thread Peter Geoghegan
On Tue, Jun 20, 2023 at 10:39 PM Andres Freund wrote: > But the further we go down this path, the more important it is that we provide > some way to monitor stuff like this. IME it's not particularly practical to > rely on scanning logs to find such issues at scale. I suspect we ought to add > at

Re: Adding further hardening to nbtree page deletion

2023-06-20 Thread Andres Freund
Hi, On 2023-06-16 14:15:08 -0700, Peter Geoghegan wrote: > Attached patch adds additional hardening to nbtree page deletion. It > makes nbtree VACUUM tolerate a certain sort of cross-page > inconsistencies in the structure of an index (corruption). VACUUM can > press on, avoiding an eventual wrapa

Re: Adding further hardening to nbtree page deletion

2023-06-20 Thread Peter Geoghegan
On Fri, Jun 16, 2023 at 2:15 PM Peter Geoghegan wrote: > Attached patch adds additional hardening to nbtree page deletion. It > makes nbtree VACUUM tolerate a certain sort of cross-page > inconsistencies in the structure of an index (corruption). VACUUM can > press on, avoiding an eventual wraparo