Re: Added missing tab completion for alter subscription set option

2021-06-13 Thread vignesh C
On Fri, Jun 11, 2021 at 12:27 PM Michael Paquier wrote: > > On Sun, May 23, 2021 at 04:24:59PM +0530, vignesh C wrote: > > /* Complete "CREATE SUBSCRIPTION ... WITH ( " */ > > else if (HeadMatches("CREATE", "SUBSCRIPTION") && TailMatches("WITH", > > "(")) > > - COMPLETE_

Re: Added missing tab completion for alter subscription set option

2021-06-10 Thread Michael Paquier
On Sun, May 23, 2021 at 04:24:59PM +0530, vignesh C wrote: > /* Complete "CREATE SUBSCRIPTION ... WITH ( " */ > else if (HeadMatches("CREATE", "SUBSCRIPTION") && TailMatches("WITH", > "(")) > - COMPLETE_WITH("copy_data", "connect", "create_slot", "enabled", > -

Re: Added missing tab completion for alter subscription set option

2021-05-23 Thread vignesh C
On Wed, May 19, 2021 at 2:03 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > > On Tue, May 18, 2021 at 9:21 PM Alvaro Herrera wrote: > > > > On 2021-May-14, vignesh C wrote: > > > > > While I was reviewing one of the logical decoding features, I found > > > Streaming and bi

Re: Added missing tab completion for alter subscription set option

2021-05-23 Thread vignesh C
On Thu, May 20, 2021 at 9:40 PM Tom Lane wrote: > > vignesh C writes: > > On Tue, May 18, 2021 at 9:20 PM Alvaro Herrera > > wrote: > >> I wish we didn't have to keep knowledge in the psql source on which > >> option names are to be used for each command. If we had some function > >> SELECT pg

Re: Added missing tab completion for alter subscription set option

2021-05-20 Thread Tom Lane
vignesh C writes: > On Tue, May 18, 2021 at 9:20 PM Alvaro Herrera > wrote: >> I wish we didn't have to keep knowledge in the psql source on which >> option names are to be used for each command. If we had some function >> SELECT pg_completion_options('alter subscription set'); >> that returned

Re: Added missing tab completion for alter subscription set option

2021-05-20 Thread vignesh C
On Tue, May 18, 2021 at 9:20 PM Alvaro Herrera wrote: > > On 2021-May-14, vignesh C wrote: > > > While I was reviewing one of the logical decoding features, I found > > Streaming and binary options were missing in tab completion for the > > alter subscription set option, the attached patch has the

Re: Added missing tab completion for alter subscription set option

2021-05-19 Thread vignesh C
On Tue, May 18, 2021 at 9:20 PM Alvaro Herrera wrote: > > On 2021-May-14, vignesh C wrote: > > > While I was reviewing one of the logical decoding features, I found > > Streaming and binary options were missing in tab completion for the > > alter subscription set option, the attached patch has the

Re: Added missing tab completion for alter subscription set option

2021-05-19 Thread Bharath Rupireddy
On Tue, May 18, 2021 at 9:21 PM Alvaro Herrera wrote: > > On 2021-May-14, vignesh C wrote: > > > While I was reviewing one of the logical decoding features, I found > > Streaming and binary options were missing in tab completion for the > > alter subscription set option, the attached patch has the

Re: Added missing tab completion for alter subscription set option

2021-05-18 Thread Alvaro Herrera
On 2021-May-14, vignesh C wrote: > While I was reviewing one of the logical decoding features, I found > Streaming and binary options were missing in tab completion for the > alter subscription set option, the attached patch has the changes for > the same. > Thoughts? I wish we didn't have to kee

Re: Added missing tab completion for alter subscription set option

2021-05-15 Thread Bharath Rupireddy
On Sat, May 15, 2021 at 10:44 AM vignesh C wrote: > I have added a commitfest entry at [1]. > Thanks for the comments, the attached patch has the changes for the same. > > [1] - https://commitfest.postgresql.org/33/3116/ Thanks Vignesh. The v3 patch looks good to me. It applies and compiles well,

Re: Added missing tab completion for alter subscription set option

2021-05-14 Thread vignesh C
On Fri, May 14, 2021 at 7:10 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > > On Fri, May 14, 2021 at 6:51 PM vignesh C wrote: > > > > On Fri, May 14, 2021 at 12:25 PM Bharath Rupireddy > > wrote: > > > > > > On Fri, May 14, 2021 at 12:00 PM vignesh C wrote: > > > > > >

Re: Added missing tab completion for alter subscription set option

2021-05-14 Thread Bharath Rupireddy
On Fri, May 14, 2021 at 6:51 PM vignesh C wrote: > > On Fri, May 14, 2021 at 12:25 PM Bharath Rupireddy > wrote: > > > > On Fri, May 14, 2021 at 12:00 PM vignesh C wrote: > > > > > > Hi, > > > > > > While I was reviewing one of the logical decoding features, I found > > > Streaming and binary op

Re: Added missing tab completion for alter subscription set option

2021-05-14 Thread vignesh C
On Fri, May 14, 2021 at 12:25 PM Bharath Rupireddy wrote: > > On Fri, May 14, 2021 at 12:00 PM vignesh C wrote: > > > > Hi, > > > > While I was reviewing one of the logical decoding features, I found > > Streaming and binary options were missing in tab completion for the > > alter subscription se

Re: Added missing tab completion for alter subscription set option

2021-05-13 Thread Bharath Rupireddy
On Fri, May 14, 2021 at 12:00 PM vignesh C wrote: > > Hi, > > While I was reviewing one of the logical decoding features, I found > Streaming and binary options were missing in tab completion for the > alter subscription set option, the attached patch has the changes for > the same. > Thoughts? +