Re: Add new wait event to XactLockTableWait

On Mon, Jun 9, 2025 at 6:55 PM Xuneng Zhou wrote: > > Hi Dilip, > > Thanks for looking into this! > > On Mon, Jun 9, 2025 at 6:56 PM Dilip Kumar wrote: >> >> > Thanks for updating the patch! It looks good to me. >> > >> > I think we can mark it as "Ready for Committer" in the CommitFest. >> > Unl

Re: Add new wait event to XactLockTableWait

Hi Fujii-san, On Mon, Jun 9, 2025 at 4:48 PM Fujii Masao wrote: > > Thanks for updating the patch! It looks good to me. > > I think we can mark it as "Ready for Committer" in the CommitFest. > Unless there are any objections, I'll commit it once v19 development opens. > I've marked it as "Ready

Re: Add new wait event to XactLockTableWait

Hi Dilip, Thanks for looking into this! On Mon, Jun 9, 2025 at 6:56 PM Dilip Kumar wrote: > > Thanks for updating the patch! It looks good to me. > > > > I think we can mark it as "Ready for Committer" in the CommitFest. > > Unless there are any objections, I'll commit it once v19 development >

Re: Add new wait event to XactLockTableWait

On Mon, Jun 9, 2025 at 2:18 PM Fujii Masao wrote: > > > > On 2025/06/09 14:19, Xuneng Zhou wrote: > > Hi, > > > > On Mon, Jun 9, 2025 at 12:52 PM Xuneng Zhou > > wrote: > > > > > > Hi, > > > > > > > Please find attached Version 2, incorporating the suggested chang

Re: Add new wait event to XactLockTableWait

On 2025/06/09 14:19, Xuneng Zhou wrote: Hi, On Mon, Jun 9, 2025 at 12:52 PM Xuneng Zhou mailto:xunengz...@gmail.com>> wrote: > > Hi, > > > Please find attached Version 2, incorporating the suggested changes. > > Apologies for the confusion — in the previous attempt, I mistakenly > name

Re: Add new wait event to XactLockTableWait

Hi, On Mon, Jun 9, 2025 at 12:52 PM Xuneng Zhou wrote: > > Hi, > > > Please find attached Version 2, incorporating the suggested changes. > > Apologies for the confusion — in the previous attempt, I mistakenly > named the patch file with a `0002-` prefix, thinking it reflected the > patch version

Re: Add new wait event to XactLockTableWait

Hi, > Please find attached Version 2, incorporating the suggested changes. Apologies for the confusion — in the previous attempt, I mistakenly named the patch file with a `0002-` prefix, thinking it reflected the patch version rather than the patch series number. I've corrected the filename to f

Re: Add new wait event to XactLockTableWait

Hi Fujii-san, Thanks for reviewing. > On 2025/06/09 7:41, Michael Paquier wrote: > > On Sun, Jun 08, 2025 at 10:30:45PM +0800, Xuneng Zhou wrote: > >> This is more problematic in logical replication scenarios where these > >> waits can be very long - for example, when creating a logical > >> rep

Re: Add new wait event to XactLockTableWait

Just CC. On Mon, Jun 9, 2025 at 10:57 AM Xuneng Zhou wrote: > > Hi Michael, > > Thanks for reviewing. > > On Mon, Jun 9, 2025 at 6:41 AM Michael Paquier wrote: > > > + pgstat_report_wait_start(WAIT_EVENT_XACT_DONE); > > [...] > > + pgstat_report_wait_start(WAIT_EVENT_XACT_DONE); > > > >

Re: Add new wait event to XactLockTableWait

On 2025/06/09 7:41, Michael Paquier wrote: On Sun, Jun 08, 2025 at 10:30:45PM +0800, Xuneng Zhou wrote: This is more problematic in logical replication scenarios where these waits can be very long - for example, when creating a logical replication slot on a busy system. Without a specific wai

Re: Add new wait event to XactLockTableWait

On Sun, Jun 08, 2025 at 10:30:45PM +0800, Xuneng Zhou wrote: > This is more problematic in logical replication scenarios where these > waits can be very long - for example, when creating a logical > replication slot on a busy system. Without a specific wait event, it's > hard to distinguish legitim