Re: Add hint message for check_log_destination()

2023-07-13 Thread Japin Li
On Thu, 13 Jul 2023 at 16:19, Masahiko Sawada wrote: > On Tue, Jul 11, 2023 at 10:24 AM Japin Li wrote: >> >> >> On Mon, 10 Jul 2023 at 14:23, Masahiko Sawada wrote: >> > On Mon, Jul 10, 2023 at 2:07 PM Kyotaro Horiguchi >> > wrote: >> >> >> >> At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wro

Re: Add hint message for check_log_destination()

2023-07-13 Thread Masahiko Sawada
On Tue, Jul 11, 2023 at 10:24 AM Japin Li wrote: > > > On Mon, 10 Jul 2023 at 14:23, Masahiko Sawada wrote: > > On Mon, Jul 10, 2023 at 2:07 PM Kyotaro Horiguchi > > wrote: > >> > >> At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wrote in > >> > > >> > On Sat, 08 Jul 2023 at 12:48, Michael Paquie

Re: Add hint message for check_log_destination()

2023-07-10 Thread Japin Li
On Mon, 10 Jul 2023 at 14:23, Masahiko Sawada wrote: > On Mon, Jul 10, 2023 at 2:07 PM Kyotaro Horiguchi > wrote: >> >> At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wrote in >> > >> > On Sat, 08 Jul 2023 at 12:48, Michael Paquier wrote: >> > > On Fri, Jul 07, 2023 at 07:23:47PM +0800, Japin L

Re: Add hint message for check_log_destination()

2023-07-09 Thread Masahiko Sawada
On Mon, Jul 10, 2023 at 2:07 PM Kyotaro Horiguchi wrote: > > At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wrote in > > > > On Sat, 08 Jul 2023 at 12:48, Michael Paquier wrote: > > > On Fri, Jul 07, 2023 at 07:23:47PM +0800, Japin Li wrote: > > >> + appendStringInfoString(&errhin

Re: Add hint message for check_log_destination()

2023-07-09 Thread Michael Paquier
On Mon, Jul 10, 2023 at 02:07:09PM +0900, Kyotaro Horiguchi wrote: > At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wrote in >> Sorry for the late reply! I'm not sure. How can I know whether it is >> translatable? Per the documentation: https://www.postgresql.org/docs/devel/nls-programmer.html#

Re: Add hint message for check_log_destination()

2023-07-09 Thread Kyotaro Horiguchi
At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wrote in > > On Sat, 08 Jul 2023 at 12:48, Michael Paquier wrote: > > On Fri, Jul 07, 2023 at 07:23:47PM +0800, Japin Li wrote: > >> + appendStringInfoString(&errhint, "\"stderr\""); > >> +#ifdef HAVE_SYSLOG > >> + a

Re: Add hint message for check_log_destination()

2023-07-09 Thread Japin Li
On Sat, 08 Jul 2023 at 12:48, Michael Paquier wrote: > On Fri, Jul 07, 2023 at 07:23:47PM +0800, Japin Li wrote: >> +appendStringInfoString(&errhint, "\"stderr\""); >> +#ifdef HAVE_SYSLOG >> +appendStringInfoString(&errhint, ", \"syslog\""); >> +#endif >>

Re: Add hint message for check_log_destination()

2023-07-07 Thread Michael Paquier
On Fri, Jul 07, 2023 at 07:23:47PM +0800, Japin Li wrote: > + appendStringInfoString(&errhint, "\"stderr\""); > +#ifdef HAVE_SYSLOG > + appendStringInfoString(&errhint, ", \"syslog\""); > +#endif > +#ifdef WIN32 > + appendStringInfoString(

Re: Add hint message for check_log_destination()

2023-07-07 Thread Japin Li
On Fri, 07 Jul 2023 at 16:21, Masahiko Sawada wrote: > On Fri, Jul 7, 2023 at 4:53 PM Japin Li wrote: >> >> >> On Fri, 07 Jul 2023 at 14:46, jian he wrote: >> > On Fri, Jul 7, 2023 at 1:06 PM Japin Li wrote: >> >> >> >> >> >> Hi, hackers >> >> >> >> When I try to change log_destination using A

Re: Add hint message for check_log_destination()

2023-07-07 Thread Masahiko Sawada
On Fri, Jul 7, 2023 at 4:53 PM Japin Li wrote: > > > On Fri, 07 Jul 2023 at 14:46, jian he wrote: > > On Fri, Jul 7, 2023 at 1:06 PM Japin Li wrote: > >> > >> > >> Hi, hackers > >> > >> When I try to change log_destination using ALTER SYSTEM with the wrong > >> value, > >> it complains of the "

Re: Add hint message for check_log_destination()

2023-07-07 Thread Japin Li
On Fri, 07 Jul 2023 at 14:46, jian he wrote: > On Fri, Jul 7, 2023 at 1:06 PM Japin Li wrote: >> >> >> Hi, hackers >> >> When I try to change log_destination using ALTER SYSTEM with the wrong value, >> it complains of the "Unrecognized key word" without available values. This >> patch tries to

Re: Add hint message for check_log_destination()

2023-07-06 Thread jian he
On Fri, Jul 7, 2023 at 1:06 PM Japin Li wrote: > > > Hi, hackers > > When I try to change log_destination using ALTER SYSTEM with the wrong value, > it complains of the "Unrecognized key word" without available values. This > patch tries to add a hint message that provides available values for >