Re: 003_check_guc.pl crashes if some extensions were loaded.

2023-11-01 Thread Anton A. Melnikov
On 02.11.2023 01:53, Michael Paquier wrote:> On Thu, Nov 02, 2023 at 12:28:05AM +0300, Anton A. Melnikov wrote: Found that src/test/modules/test_misc/t/003_check_guc.pl will crash if an extension that adds own GUCs was loaded into memory. So it is now impossible to run a check-world with loaded

Re: 003_check_guc.pl crashes if some extensions were loaded.

2023-11-01 Thread Michael Paquier
On Wed, Nov 01, 2023 at 07:29:51PM -0400, Tom Lane wrote: > Actually we do force that, see valid_custom_variable_name(). > But I think your idea is better. Ah, indeed, thanks. I didn't recall this was the case. -- Michael signature.asc Description: PGP signature

Re: 003_check_guc.pl crashes if some extensions were loaded.

2023-11-01 Thread Tom Lane
Michael Paquier writes: > On Thu, Nov 02, 2023 at 12:28:05AM +0300, Anton A. Melnikov wrote: >> "SELECT name >> FROM pg_settings >> WHERE NOT 'NOT_IN_SAMPLE' = ANY (pg_settings_get_flags(name)) AND >> - name <> 'config_file' >> + name <> 'config_file' AND name NOT LIKE '%.%' >> ORDER B

Re: 003_check_guc.pl crashes if some extensions were loaded.

2023-11-01 Thread Michael Paquier
On Thu, Nov 02, 2023 at 12:28:05AM +0300, Anton A. Melnikov wrote: > Found that src/test/modules/test_misc/t/003_check_guc.pl will crash if an > extension > that adds own GUCs was loaded into memory. > So it is now impossible to run a check-world with loaded extension libraries. Right. That's an