Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Nathan Bossart
On Wed, Oct 04, 2023 at 12:24:36PM -0400, Tom Lane wrote: > In any case, trying to standardize this looks like it would be a > huge amount of churn for very little gain. I'd recommend making > your markup look similar to what's immediately adjacent, if possible, > and not sweating too much otherwi

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Tom Lane
Robert Haas writes: > On Wed, Oct 4, 2023 at 11:27 AM Nathan Bossart > wrote: >> Here's a patch. I didn't address the class="parameter" stuff at all. I >> figured it would be best to handle that separately. > I guess I'll vote for including class=parameter in this addition for > now, as that

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Nathan Bossart
On Wed, Oct 04, 2023 at 11:51:32AM -0400, Robert Haas wrote: > On Wed, Oct 4, 2023 at 11:27 AM Nathan Bossart > wrote: >> Here's a patch. I didn't address the class="parameter" stuff at all. I >> figured it would be best to handle that separately. > > I guess I'll vote for including class=para

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Robert Haas
On Wed, Oct 4, 2023 at 11:27 AM Nathan Bossart wrote: > Here's a patch. I didn't address the class="parameter" stuff at all. I > figured it would be best to handle that separately. I guess I'll vote for including class=parameter in this addition for now, as that appears to be the majority posit

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Nathan Bossart
On Wed, Oct 04, 2023 at 05:00:26PM +0200, Alvaro Herrera wrote: > On 2023-Oct-04, Robert Haas wrote: > >> The original issue I reported does make a real difference, though. :-) > > Yes, absolutely, and I agree that it'd be better to get it fixed. Here's a patch. I didn't address the class="para

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Daniel Gustafsson
> On 4 Oct 2023, at 17:07, Tom Lane wrote: > OK, so now I know what the possible values of "class" are, but > I'm still not seeing a reason why we shouldn't just assume that > "parameter" is the only one of interest. I think "parameter" is the only one of interest for this usecase (params to app

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Tom Lane
Daniel Gustafsson writes: > On 4 Oct 2023, at 16:51, Tom Lane wrote: >> To do that, we'd need some sort of agreement on what the possible >> "class" values are and when to use each one. I've never seen any >> documentation about that. > Thats fair. The 4.5 docbook guide isn't terribly helpful

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Alvaro Herrera
On 2023-Oct-04, Robert Haas wrote: > The original issue I reported does make a real difference, though. :-) Yes, absolutely, and I agree that it'd be better to get it fixed. -- Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/ "Learn about compilers. Then everything

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Daniel Gustafsson
> On 4 Oct 2023, at 16:51, Tom Lane wrote: > > Daniel Gustafsson writes: >> On 4 Oct 2023, at 16:39, Tom Lane wrote: >>> I concluded a long time ago that it does nothing. > >> It does nothing in our current doc rendering, but if someone would like to >> render docs with another style where it

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Nathan Bossart
On Wed, Oct 04, 2023 at 09:08:57AM -0400, Robert Haas wrote: > The various command-line utilities that have recently acquired a > --sync-method option document it like this: > > --sync-method > > But that is not how we document options which take an argument. We do > it like this: > > --pgdata=dire

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Tom Lane
Daniel Gustafsson writes: > On 4 Oct 2023, at 16:39, Tom Lane wrote: >> I concluded a long time ago that it does nothing. > It does nothing in our current doc rendering, but if someone would like to > render docs with another style where it does make a difference it seems > unhelpful to not be c

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Daniel Gustafsson
> On 4 Oct 2023, at 16:39, Tom Lane wrote: > > Alvaro Herrera writes: >> So I'm not sure that specifying the class="parameter" bit does anything in >> reality, or that changing lines to add or remove it will have any effect. > > I concluded a long time ago that it does nothing. It does nothing

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Tom Lane
Alvaro Herrera writes: > So I'm not sure that specifying the class="parameter" bit does anything in > reality, or that changing lines to add or remove it will have any effect. I concluded a long time ago that it does nothing. We have a good mix of places that write with or without that, and I'v

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Robert Haas
On Wed, Oct 4, 2023 at 10:35 AM Alvaro Herrera wrote: > So I'm not sure that specifying the class="parameter" bit does anything in > reality, or that changing lines to add or remove it will have any effect. Interesting. I wondered whether that might be the case. The original issue I reported doe

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Alvaro Herrera
On 2023-Oct-04, Daniel Gustafsson wrote: > I can take a stab at tidying this up during breaks at the conference. It > might > not be the most important bit of markup, but for anyone building the docs who > might want to use this it seems consistency will help. So for HTML, the result of the pg_

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Daniel Gustafsson
> On 4 Oct 2023, at 15:22, Robert Haas wrote: > > On Wed, Oct 4, 2023 at 9:15 AM Daniel Gustafsson wrote: >>> On 4 Oct 2023, at 15:08, Robert Haas wrote: >>> This one should be something like this: >>> >>> --sync-method=method >> >> Shouldn't it be method ? > > Hmm, I think you're probably r

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Robert Haas
On Wed, Oct 4, 2023 at 9:15 AM Daniel Gustafsson wrote: > > On 4 Oct 2023, at 15:08, Robert Haas wrote: > > This one should be something like this: > > > > --sync-method=method > > Shouldn't it be method ? Hmm, I think you're probably right. But look at this: -S slotname --slot=slot

Re: --sync-method isn't documented to take an argument

2023-10-04 Thread Daniel Gustafsson
> On 4 Oct 2023, at 15:08, Robert Haas wrote: > This one should be something like this: > > --sync-method=method Shouldn't it be method ? -- Daniel Gustafsson