On Wed, Aug 25, 2021 at 11:26 AM Drouvot, Bertrand wrote:
>
> I just saw that the patch has been committed.
>
> Thanks for your help and time on this.
>
> I'll mark the corresponding commitfest entry as "Committed".
>
Thanks for your work on this. I have also marked it closed in
PostgreSQL_14_Ope
On Wed, Aug 18, 2021 at 8:09 PM Drouvot, Bertrand wrote:
>
> Hi,
>
> On 8/18/21 12:01 PM, Amit Kapila wrote:
> > On Wed, Aug 18, 2021 at 1:27 PM Drouvot, Bertrand
> > wrote:
> >> Hi,
>
> I've updated the comment and prepared the back patch versions:
>
I have verified and all your patches look g
On Wed, Aug 18, 2021 at 1:27 PM Drouvot, Bertrand wrote:
>
> Hi,
>
> On 8/13/21 11:17 AM, Amit Kapila wrote:
> > On Fri, Aug 13, 2021 at 11:47 AM Drouvot, Bertrand
> > wrote:
> >> On 8/12/21 1:00 PM, Amit Kapila wrote:
> - sets "relwrewrite" for the toast.
>
> >>> --- a/src/backend/com
Hi Drouvot,
I don't see extra data in your output and it looks like your
copy/paste is missing some content, no?
On my side, that looks good and here is what i get with the patch applied:
I ran the test again, now I got the same output as yours, and it looks
good for me. (The issue I mention
On Fri, Aug 13, 2021 at 11:47 AM Drouvot, Bertrand wrote:
>
> On 8/12/21 1:00 PM, Amit Kapila wrote:
> >>
> >> - sets "relwrewrite" for the toast.
> >>
> > --- a/src/backend/commands/tablecmds.c
> > +++ b/src/backend/commands/tablecmds.c
> > @@ -3861,6 +3861,10 @@ RenameRelationInternal(Oid myreli
On Thu, Aug 12, 2021 at 4:30 PM Amit Kapila wrote:
>
> On Tue, Aug 10, 2021 at 5:30 PM Drouvot, Bertrand wrote:
> >
> >
> > Please find attached the new version that:
> >
> > - sets "relwrewrite" for the toast.
> >
>
> --- a/src/backend/commands/tablecmds.c
> +++ b/src/backend/commands/tablecmds.
On Tue, Aug 10, 2021 at 5:30 PM Drouvot, Bertrand wrote:
>
> Hi Amit,
>
> On 8/9/21 1:12 PM, Amit Kapila wrote:
> > On Mon, Aug 9, 2021 at 3:37 PM Drouvot, Bertrand
> > wrote:
> >> Hi Amit,
> >>
> >> On 8/9/21 10:37 AM, Amit Kapila wrote:
> >>> On Fri, Jul 9, 2021 at 12:22 PM Drouvot, Bertrand
On Thu, Aug 12, 2021 at 12:15 PM Drouvot, Bertrand wrote:
>
> On 8/10/21 1:59 PM, Drouvot, Bertrand wrote:
> > Hi Amit,
> >
>
> The first version of the patch contained a change in
> ReorderBufferToastReplace() (to put the call to
> RelationIsValid(toast_rel) and display the error message when it
On Mon, Aug 9, 2021 at 3:37 PM Drouvot, Bertrand wrote:
>
> > BTW, I see this as an Open Item for PG-14 [1] which seems wrong to me
> > as this is a bug from previous versions. I am not sure who added it
>
> Me neither.
>
> > but do you see any reason for this to consider as an open item for
> > P
On Mon, Aug 9, 2021 at 3:37 PM Drouvot, Bertrand wrote:
>
> Hi Amit,
>
> On 8/9/21 10:37 AM, Amit Kapila wrote:
> > On Fri, Jul 9, 2021 at 12:22 PM Drouvot, Bertrand
> > wrote:
> >> Please find enclosed a patch proposal to:
> >>
> >> * Avoid the failed assertion on current master and generate th
On Mon, Aug 9, 2021 at 2:07 PM Amit Kapila wrote:
>
> On Fri, Jul 9, 2021 at 12:22 PM Drouvot, Bertrand wrote:
> >
> > Please find enclosed a patch proposal to:
> >
> > * Avoid the failed assertion on current master and generate the error
> > message instead (should the code reach that stage).
>
On Fri, Jul 9, 2021 at 12:22 PM Drouvot, Bertrand wrote:
>
> Please find enclosed a patch proposal to:
>
> * Avoid the failed assertion on current master and generate the error message
> instead (should the code reach that stage).
> * Reset the toast_hash in case of relation rewrite with toast (s
Hi Drouvot,
I can reproduce the issue you mentioned on REL_12_STABLE as well as Master
branch, but the patch doesn't apply to REL_12_STABLE. After applied it to
Master branch, it returns some wired result when run the query in the first
time.
As you can see in the log below, after the first tim
13 matches
Mail list logo
